diff options
author | Matt Sarett <msarett@google.com> | 2016-12-16 16:28:17 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-12-16 22:13:28 +0000 |
commit | fc8dc3194acb959ee5980b41766660ca0644bcab (patch) | |
tree | d894d51cc1a9984a7e147d80eefe4fff16ff8b1c /src/core/SkColorSpace_A2B.h | |
parent | 0eb6ed421ccd4f8a84ef5e5a11df73a00d210aec (diff) |
WIP: Skia support library for ICC tasks
As a starting point, this would be mostly trivial to implement using
SkColorSpace.
This also would give us the flexibility to begin to move all of
the ICC related code from SkColorSpace to SkICC.
What are the advantages of moving this away from SkColorSpace?
(1) A long term goal (once Chrome uses SkCodec), might be to
move SkColorSpace::MakeICC() out of the public API. That way,
we can guarantee that we can draw to/from *any* SkColorSpace.
(2) Keeps SkColorSpace separate from ICC-specific representations
like SkColorSpaceTransferFn etc.
BUG=skia:
Change-Id: Iddeb9903221fb57fbfc01218d8641c928b4a5165
Reviewed-on: https://skia-review.googlesource.com/5676
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Diffstat (limited to 'src/core/SkColorSpace_A2B.h')
-rw-r--r-- | src/core/SkColorSpace_A2B.h | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/src/core/SkColorSpace_A2B.h b/src/core/SkColorSpace_A2B.h index ed90713a2c..084c5934ce 100644 --- a/src/core/SkColorSpace_A2B.h +++ b/src/core/SkColorSpace_A2B.h @@ -47,15 +47,10 @@ public: return nullptr; } - bool onGammaCloseToSRGB() const override { - // There is no single gamma curve in an A2B0 profile - return false; - } - - bool onGammaIsLinear() const override { - // There is no single gamma curve in an A2B0 profile - return false; - } + // There is no single gamma curve in an A2B0 profile + bool onGammaCloseToSRGB() const override { return false; } + bool onGammaIsLinear() const override { return false; } + bool onIsNumericalTransferFn(SkColorSpaceTransferFn* coeffs) const override { return false; } sk_sp<SkColorSpace> makeLinearGamma() override { // TODO: Analyze the extrema of our projection into XYZ and use suitable primaries? |