diff options
author | Mike Klein <mtklein@chromium.org> | 2017-10-10 11:30:10 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-10-10 16:31:25 +0000 |
commit | 24f0a354ac618c17a71e4dac80dd0ad370ed14eb (patch) | |
tree | 1adf5d38af78117c408845cf903a56ede144ceae /src/core/SkClipOpPriv.h | |
parent | 1a3457d3fc1a4a11a2436828878aa1f27de78b2f (diff) |
SkColorSpaceXform: clamp before table lookups
The fuzzer has built a single test case that causes out-of-bounds
reads on both the src and dst tables. I'm glad we have it.
Next follow ups may include:
- have byte_tables_rgb do its own clamping
- replace table_{r,g,b} here with a single stage analogous
to byte_tables_rgb that looks up the three float tables
safely
- maybe replace byte_tables_rgb with that. I'm not really
sure why src->XYZ tables are floats but XYZ->dst are bytes.
I'm going to try some of these out before attempting to reland
in Chrome. As usual, rebaselining Blink makes things a pain.
Bug: chromium:772684, skia:7114
Change-Id: Id8759e766330e1c7689c0847bf2cd35d422ebbcd
Reviewed-on: https://skia-review.googlesource.com/57760
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'src/core/SkClipOpPriv.h')
0 files changed, 0 insertions, 0 deletions