aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkBlitter.h
diff options
context:
space:
mode:
authorGravatar Yuqian Li <liyuqian@google.com>2018-04-11 17:09:12 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-04-16 18:53:10 +0000
commit94bb0722b238ac24e45863462d943b7b3d82cdb0 (patch)
tree2432ba485b91aa4a3f80f5e9385e5e7b398c78f1 /src/core/SkBlitter.h
parent6b7b1dcc863ae8877f33532df05c921e12c67675 (diff)
SkBlitter is not thread safe; make one for each thread.
Otherwise, GM fancy_gradients would be drawn incorrectly and TSAN will issue alerts as SkARGB32_Shader_Blitter has its own memory that may be written during blitting. As we make one blitter for each thread, we also don't need to send in a thread-alloc for blitCoverageDeltas Bug: skia: Change-Id: Ie4ee0886b88c797ab57c65674b0b7527501b164f Reviewed-on: https://skia-review.googlesource.com/120641 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
Diffstat (limited to 'src/core/SkBlitter.h')
-rw-r--r--src/core/SkBlitter.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/core/SkBlitter.h b/src/core/SkBlitter.h
index 357eb46941..c280ac37b7 100644
--- a/src/core/SkBlitter.h
+++ b/src/core/SkBlitter.h
@@ -36,8 +36,7 @@ public:
// For example, one may avoid some virtual blitAntiH calls by directly calling
// SkBlitRow::Color32.
virtual void blitCoverageDeltas(SkCoverageDeltaList* deltas, const SkIRect& clip,
- bool isEvenOdd, bool isInverse, bool isConvex,
- SkArenaAlloc* alloc);
+ bool isEvenOdd, bool isInverse, bool isConvex);
/// Blit a horizontal run of one or more pixels.
virtual void blitH(int x, int y, int width) = 0;