diff options
| author |  Yuqian Li <liyuqian@google.com> | 2018-04-16 13:49:39 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-04-16 16:14:30 +0000 |
| commit | ffbe93296838c3a93a87261cae7f7229b56f1f8a (patch) | |
| tree | 22bfaaa2c04f09944bc745b1f259cd5672f70960 /src/core/SkBlitter.cpp | |
| parent | 6fdbf6161bcb299f855fd467ac4cdbf38c14a5cb (diff) | |
Revert "Cumulate deltas even if they're out of the clip"
This reverts commit 520e578b9987ea99b8ee62b485e941b3d5d96e0f.
Reason for revert: guard flag isn't in yet
Original change's description:
> Cumulate deltas even if they're out of the clip
>
> Otherwise, GM complexclip_aa_inverse will be drawn incorrectly
> in t8888 mode.
>
> Bug: skia:
> Change-Id: I2fe9dd94f3219e3883f713ca95ea3c3d8a49c7ba
> Reviewed-on: https://skia-review.googlesource.com/121261
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
TBR=caryclark@google.com,liyuqian@google.com,reed@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:
Change-Id: If7fa2a8bd1ff3e9b55c3900cbba82a3e2562f502
Reviewed-on: https://skia-review.googlesource.com/121424
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Diffstat (limited to 'src/core/SkBlitter.cpp')
| -rw-r--r-- | src/core/SkBlitter.cpp | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/src/core/SkBlitter.cpp b/src/core/SkBlitter.cpp index 18b9d83048..0a642ca4f6 100644 --- a/src/core/SkBlitter.cpp +++ b/src/core/SkBlitter.cpp @@ -129,15 +129,9 @@ void SkBlitter::blitCoverageDeltas(SkCoverageDeltaList* deltas, const SkIRect& c int lastX = clip.fLeft; // init x to clip.fLeft SkFixed coverage = 0; // init coverage to 0 - // skip deltas with x less than clip.fLeft; they may be: - // 1. precision errors - // 2. deltas generated during init-once phase (threaded backend) that has a wider - // clip than the final tile clip. - for(; i < deltas->count(y) && deltas->getDelta(y, i).fX < clip.fLeft; ++i) { -#ifndef SK_SUPPORT_LEGACY_THREADED_DAA_BUGS - coverage += deltas->getDelta(y, i).fDelta; -#endif - } + // skip deltas with x less than clip.fLeft; they must be precision errors + for(; i < deltas->count(y) && deltas->getDelta(y, i).fX < clip.fLeft; ++i) + ; for(; i < deltas->count(y) && deltas->getDelta(y, i).fX < clip.fRight; ++i) { const SkCoverageDelta& delta = deltas->getDelta(y, i); SkASSERT(delta.fX >= lastX); // delta must be x sorted |