aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkBitmapCache.h
diff options
context:
space:
mode:
authorGravatar tomhudson <tomhudson@google.com>2015-12-07 10:38:05 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2015-12-07 10:38:05 -0800
commitd5c4265b49d212f7888d0516328f39c4d45d3058 (patch)
treefa6394fa20aa2c2bf26f1aa9efa88d0ff2da5122 /src/core/SkBitmapCache.h
parentd18b1b5adc15afd9b57ddecf779dccbcc85098f1 (diff)
Fix up signed-integer-overflow warnings
When checking whether a matrix was a pure scale, we subtracted 0x3f800000 from the diagonals; if the diagonal value was already very negative, we'd underflow. Replace subtraction with XOR. When dealing with repeating tiled bitmaps, when the bitmap was very large, we'd multiply an offset by 65535, possibly causing underflow. Throw in a cast to long (casting to unsigned also silences the warning and wouldn't involve extension, but I can't convince myself that it's correct). BUG=skia:4635 R=mtklein@google.com Review URL: https://codereview.chromium.org/1504933002
Diffstat (limited to 'src/core/SkBitmapCache.h')
0 files changed, 0 insertions, 0 deletions