diff options
author | brucedawson <brucedawson@chromium.org> | 2016-02-06 12:40:56 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-06 12:40:56 -0800 |
commit | 964eec67760196585954203ba625e440607f7e92 (patch) | |
tree | 98f4388c0f1e200f7a37c678e2f1abaa2eec1727 /src/core/SkBBHFactory.cpp | |
parent | f1036b2c6610e106b299a1e2b69b814ff18b60f5 (diff) |
Add non-inline SkRTreeFactory constructor to fix clang-cl
When Chromium is switched to build with VS 2015 that switches clang-cl
to build in -fmsc-version=1900 mode. This causes some changes in
importing of constructors and vftables which leads to link errors in
blink_platform.dll. Adding a non-inline constructor makes 1900 mode
behave consistently with 1800 mode and avoids the link error.
The root cause needs investigation but this will unblock the VS 2015
switch.
BUG=440500,498544
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676833002
Review URL: https://codereview.chromium.org/1676833002
Diffstat (limited to 'src/core/SkBBHFactory.cpp')
-rw-r--r-- | src/core/SkBBHFactory.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/core/SkBBHFactory.cpp b/src/core/SkBBHFactory.cpp index e8534cacb3..b10dc985f8 100644 --- a/src/core/SkBBHFactory.cpp +++ b/src/core/SkBBHFactory.cpp @@ -14,3 +14,7 @@ SkBBoxHierarchy* SkRTreeFactory::operator()(const SkRect& bounds) const { SkScalar aspectRatio = bounds.width() / bounds.height(); return new SkRTree(aspectRatio); } + +// TODO(thakis@chromium): remove once HTTP://llvm.org/26506 is fixed +SkRTreeFactory::SkRTreeFactory() { +} |