diff options
| author |  Yuqian Li <liyuqian@google.com> | 2016-11-28 21:38:18 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-11-28 21:38:32 +0000 |
| commit | 44be067730b9bff2027b41691587a1b0454966a1 (patch) | |
| tree | af982e09291b7d25f493756d2d7279a08f5e509d /src/core/SkAnalyticEdge.cpp | |
| parent | e03339a35435b6c4b9ddb5b9d1d3592be5185de2 (diff) | |
Revert "Add the missing shift to the dy"
This reverts commit dd13c020793b0a7fb2ac1f22024e9fb91ea483ef.
Reason for revert: this breaks the Chromium DEPS roll as we break the layout_tests. I'll add a flag to guard the change in the future and enable the flag while change the layout_tests.
Original change's description:
> Add the missing shift to the dy
>
> BUG=chromium:668907
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5266
>
> Change-Id: I6d3e56ffc149fbeac6f7a2df740542abbf84dac8
> Reviewed-on: https://skia-review.googlesource.com/5266
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>
>
TBR=mtklein@chromium.org,caryclark@google.com,liyuqian@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ifd5aa50f155c3ebe2f1495cbf3b8dd706211a639
Reviewed-on: https://skia-review.googlesource.com/5286
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Diffstat (limited to 'src/core/SkAnalyticEdge.cpp')
| -rw-r--r-- | src/core/SkAnalyticEdge.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/SkAnalyticEdge.cpp b/src/core/SkAnalyticEdge.cpp index 862f88d043..a9cbc50204 100644 --- a/src/core/SkAnalyticEdge.cpp +++ b/src/core/SkAnalyticEdge.cpp @@ -106,7 +106,7 @@ bool SkAnalyticQuadraticEdge::updateQuadratic() { newx = oldx + (dx >> shift); newy = oldy + (dy >> shift); slope = dy >> 10 > 0 ? QuickSkFDot6Div(dx >> 10, dy >> 10) : SK_MaxS32; - if (SkAbs32(dy >> shift) >= SK_Fixed1 * 2) { // only snap when dy is large enough + if (SkAbs32(dy) >= SK_Fixed1 * 2) { // only snap when dy is large enough newSnappedY = SkTMin<SkFixed>(fQEdge.fQLastY, SkFixedRoundToFixed(newy)); newSnappedX = newx + SkFixedMul(slope, newSnappedY - newy); } else { |