diff options
| author |  mtklein <mtklein@chromium.org> | 2016-04-21 10:34:41 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-04-21 10:34:41 -0700 |
| commit | eb85fd746d6390f53e250583a0544bf59ed34b35 (patch) | |
| tree | 869cf1b643bb5e796743e39a91c102f630c05560 /src/animator/SkDump.cpp | |
| parent | 730058f6a89c0d949d2be539be08a935e78c6d8e (diff) | |
SkCpu w/o static initializer
I think I cracked it.
Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.
Is this...
- legal C++?
- not C++ but probably works as I think?
- not C++ and will probably blow up?
- who knows, let's see?
I have tested that the features are cached properly, read properly, and that the generated code treats SkCpu::gCachedFeatures as a global constant outside SkCpu.cpp. So it all observably works optimally.
Expanding testing to more bots.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905683003
Review URL: https://codereview.chromium.org/1905683003
Diffstat (limited to 'src/animator/SkDump.cpp')
0 files changed, 0 insertions, 0 deletions