diff options
| author |  Ben Wagner <benjaminwagner@google.com> | 2018-06-19 10:34:32 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-19 17:29:15 +0000 |
| commit | 96aa535b782f31df0f063213c2958acba32a808d (patch) | |
| tree | b31c2ac0ba3c7e84f648fec46b4d2e29267b78d8 /site | |
| parent | ba61029c5b4939fc33a8cd5db3e7e19c6742cc4b (diff) | |
Remove .bat and .exe from commands where possible.
We expect .BAT and .EXE to be on PATHEXT. Also, although Python
CreateProcess doesn't honor PATHEXT, it will try .EXE. This allows most
commands to be platform-independent, and also resolves the issue with
the cpython package not including python.bat.
No-Tree-Checks: true
Docs-Preview: https://skia.org/?cl=135626
Bug: chromium:852581
Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397
Reviewed-on: https://skia-review.googlesource.com/135626
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Diffstat (limited to 'site')
| -rw-r--r-- | site/user/build.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/site/user/build.md b/site/user/build.md index 899a11b581..eaf0f68b1c 100644 --- a/site/user/build.md +++ b/site/user/build.md @@ -263,6 +263,8 @@ You can then pass the VC and SDK paths to GN by setting your GN args: This toolchain is the only way we support 32-bit builds, by also setting `target_cpu="x86"`. There is also a corresponding 2015 toolchain, downloaded via `infra/bots/assets/win_toolchain_2015`. +The Skia build assumes that the PATHEXT environment variable contains ".EXE". + ### Visual Studio Solutions If you use Visual Studio, you may want to pass `--ide=vs` to `bin/gn gen` to |