diff options
| author |  reed <reed@google.com> | 2016-04-28 08:12:55 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-04-28 08:12:55 -0700 |
| commit | 28d5bdd97ebbbdfff49d2e719b24a6343b0f0b48 (patch) | |
| tree | 0844d9f033c93102c900b7b4e11604e7d53a907e /site | |
| parent | 9fbee8408ec4578aead049f1bf43f1d9d4039b7b (diff) | |
Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (patchset #2 id:20001 of https://codereview.chromium.org/1927583002/ )
Reason for revert:
still blocking DEPS roll
Original issue's description:
> Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
>
> The Release_Developer build type is now used to build Skia with
> release level optimizations but still enable SK_DEBUG. This in turn
> means that SkASSERTS and SkRTConf are available in this mode.
>
> Further we can then remove SK_DEVELOPER as a define as it is true
> iff SK_DEBUG is true.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002
> DOCS_PREVIEW= https://skia.org/?cl=1927583002
>
> Committed: https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db
TBR=bungeman@gmail.com,bungeman@google.com,benjaminwagner@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1918253006
Diffstat (limited to 'site')
| -rw-r--r-- | site/dev/runtime/index.md | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/site/dev/runtime/index.md b/site/dev/runtime/index.md index 7c8246d23f..b7e656b29f 100644 --- a/site/dev/runtime/index.md +++ b/site/dev/runtime/index.md @@ -152,10 +152,11 @@ options. ## Are these things enabled all the time? -No, they are only enabled in builds where SK_DEBUG is defined. This includes both -`Debug` and `Release_Developer` gyp BUILDTYPES. The `Release_Developer` build type -has exactly the same build flags as `Release`, except it re-enables SK_DEBUG, which -in turn enables runtime configuration behavior. +In `Debug` builds, yes. `Release` builds disable runtime configuration by +default, but it is still useful to be able to tweak certain algorithm parameters +at runtime to do scripted performance studies. Therefore, a third build type, +`Release_Developer` has been added. This build type has exactly the same build +flags as `Release`, except it re-enables all runtime configuration behavior. Specifically: <!--?prettify?--> @@ -179,3 +180,7 @@ Runtime configuration variables of type `char \* ` cannot currently have spaces in them. Runtime variables are only fully supported for `int`, `unsigned int`, `float`, `double`, `bool`, and `char \*`. + +## Questions? Bugs? Improvements? + +Feel free to send feedback on this system to Greg Humphreys \(humper@google\.com\) |