diff options
| author |  pdr <pdr@chromium.org> | 2016-07-07 14:48:52 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-07-07 14:48:53 -0700 |
| commit | c42475cea23bfdb22b5d6cad6042577e47bd6a5c (patch) | |
| tree | 19766e8104059e72e42d7c1a3a058a3d30bde976 /site/dev/tools | |
| parent | 45e58c8807179638980aae8503573b950b844e4c (diff) | |
Update markdown to use absolute image paths, fixing broken images
Markdown can be served with or without a trailing slash but when a
trailing slash is present, relative image links were broken.
The following example works as expected:
url: https://skia.org/dev/design/pdftheory
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/PdfLogicalDocumentStructure.png
The following example was broken before this patch:
url: https://skia.org/dev/design/pdftheory/
image url: PdfLogicalDocumentStructure.png
resolves to: https://skia.org/dev/design/pdftheory/PdfLogicalDocumentStructure.png
The PdfLogicalDocumentStructure.png file lives in /dev/design/, not
/dev/design/pdftheory/. This patch updates all images in our markdown
files to be served with the full path so a trailing slash no longer
breaks images.
I hit this bug when promoting the new Skia debugger:
https://groups.google.com/a/chromium.org/d/msg/paint-dev/QJ8xpu8dNyA/F4KX2O4ZBwAJ
BUG=skia:5493
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128013003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2128013003
Review-Url: https://codereview.chromium.org/2128013003
Diffstat (limited to 'site/dev/tools')
| -rw-r--r-- | site/dev/tools/debugger.md | 2 | ||||
| -rw-r--r-- | site/dev/tools/markdown.md | 2 | ||||
| -rw-r--r-- | site/dev/tools/qtdebugger.md | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/site/dev/tools/debugger.md b/site/dev/tools/debugger.md index cd0762594c..8a82287b98 100644 --- a/site/dev/tools/debugger.md +++ b/site/dev/tools/debugger.md @@ -26,4 +26,4 @@ Begin by following the instructions to After running `skiaserve`, follow the instructions to open the debugger in your local browser. By default the address will be `http://127.0.0.1:8888`. - + diff --git a/site/dev/tools/markdown.md b/site/dev/tools/markdown.md index dc7c5d1a83..59551a47e1 100644 --- a/site/dev/tools/markdown.md +++ b/site/dev/tools/markdown.md @@ -71,7 +71,7 @@ ordered and unordered lists: Incorporate images: - + Or go old school and use [ASCII art](http://asciiflow.com/): diff --git a/site/dev/tools/qtdebugger.md b/site/dev/tools/qtdebugger.md index e3c5a1f5b7..bb3f97eba6 100644 --- a/site/dev/tools/qtdebugger.md +++ b/site/dev/tools/qtdebugger.md @@ -115,6 +115,6 @@ down below. ctrl-shift-s | Saves the skp under the new specified name ctrl-q | Quits - + |