aboutsummaryrefslogtreecommitdiffhomepage
path: root/site/dev/contrib
diff options
context:
space:
mode:
authorGravatar bungeman <bungeman@google.com>2015-04-17 13:51:08 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-04-17 13:51:08 -0700
commite85a754a4ce9b279159270faa6717932f7a8548f (patch)
tree6d378ab2768b94de77753f17e7589b8e0fe907bf /site/dev/contrib
parent21d3ed52e5eecc41f0ed05acdd3c5ff1189fed75 (diff)
Respect declared font style on Android.
Previously the normal/italic style bit was obtained from scanning the font file. With the new format the style may be stated explicitly, and this explicit value in the configuration file should override any information obtained from the font data itself. This change allows the font element's style attribute to override the font's style, but retains the default 'auto' setting for backwards compatibility. Repecting the style bit may become more important with variation fonts, because it will be up to the configuration writer to determine what values of the 'slnt' variation should be considered 'normal' or 'italic'. DOCS_PREVIEW= https://skia.org/?cl=1092093002 Committed: https://skia.googlesource.com/skia/+/673e902c9b9982a167f54f1cc175d8d9cab8bcaf Review URL: https://codereview.chromium.org/1092093002
Diffstat (limited to 'site/dev/contrib')
-rw-r--r--site/dev/contrib/style.md17
1 files changed, 13 insertions, 4 deletions
diff --git a/site/dev/contrib/style.md b/site/dev/contrib/style.md
index e952ed1b68..177a58b8d4 100644
--- a/site/dev/contrib/style.md
+++ b/site/dev/contrib/style.md
@@ -78,10 +78,19 @@ int herdCats(const Array& cats) {
}
~~~~
-Enum values are prefixed with k and have post fix that consists of an underscore
-and singular name of the enum name. The enum itself should be singular for
-exclusive values or plural for a bitfield. If a count is needed it is
-k<singular enum name>Count and not be a member of the enum (see example):
+Enum values are prefixed with k. Unscoped enum values are post fixed with
+an underscore and singular name of the enum name. The enum itself should be
+singular for exclusive values or plural for a bitfield. If a count is needed it
+is k&lt;singular enum name&gt;Count and not be a member of the enum (see example):
+
+<!--?prettify?-->
+~~~~
+enum class SkPancakeType {
+ kBlueberry,
+ kPlain,
+ kChocolateChip,
+};
+~~~~
<!--?prettify?-->
~~~~