diff options
| author |  Hal Canary <halcanary@google.com> | 2017-11-20 12:43:51 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-11-20 19:09:18 +0000 |
| commit | c60dea17d8fa72bad158a53d1e4df113ed8f92c2 (patch) | |
| tree | c79d627c207ad85b7b39a530191729f1ad2f18fc /site/dev/contrib | |
| parent | 0c1c2b39dd93100542236b23546ed0b855816a49 (diff) | |
style nit: s/RIGHT SINGLE QUOTATION MARK/APOSTROPHE/g when apropriate
Change-Id: If834febee09266cad6a7a2fb64b06adc25790e33
Reviewed-on: https://skia-review.googlesource.com/73742
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Diffstat (limited to 'site/dev/contrib')
| -rw-r--r-- | site/dev/contrib/style.md | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/site/dev/contrib/style.md b/site/dev/contrib/style.md index 639738c28f..17989b3c82 100644 --- a/site/dev/contrib/style.md +++ b/site/dev/contrib/style.md @@ -2,7 +2,7 @@ Coding Style Guidelines ======================= These conventions have evolved over time. Some of the earlier code in both -projects doesn’t strictly adhere to the guidelines. However, as the code evolves +projects doesn't strictly adhere to the guidelines. However, as the code evolves we hope to make the existing code conform to the guildelines. Files @@ -11,8 +11,8 @@ Files We use .cpp and .h as extensions for c++ source and header files. We use foo_impl.h for headers with inline definitions for class foo. -Headers that aren’t meant for public consumption should be placed in src -directories so that they aren’t in a client’s search path. +Headers that aren't meant for public consumption should be placed in src +directories so that they aren't in a client's search path. We prefer to minimize includes. If forward declaring a name in a header is sufficient then that is preferred to an include. @@ -41,7 +41,7 @@ Naming ------ Both projects use a prefix to designate that they are Skia prefix for classes, -enums, structs, typedefs etc is Sk. Ganesh’s is Gr. Nested types should not be +enums, structs, typedefs etc is Sk. Ganesh's is Gr. Nested types should not be prefixed. <!--?prettify?--> @@ -184,7 +184,7 @@ Skia tends to use #ifdef SK_MACRO for boolean flags. Braces ------ -Open braces don’t get a newline. “else” and “else if” appear on same line as +Open braces don't get a newline. “else” and “else if” appear on same line as opening and closing braces unless preprocessor conditional compilation interferes. Braces are always used with if, else, while, for, and do. |