diff options
| author |  mtklein <mtklein@chromium.org> | 2015-08-05 13:08:12 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-08-05 13:08:12 -0700 |
| commit | 94df02344bd819a6aff0e9fdd31c2e9ba9bab34d (patch) | |
| tree | b70c53cc015aef46a0af2d0d42c31f86de4c4464 /site/dev/contrib | |
| parent | 99f567e617b6c5a81e6b822c30ccb0d357db21fc (diff) | |
Update NOPRESUBMIT docs.
"NOPRESUBMIT=true" does not work anymore for me.
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1271423002
Review URL: https://codereview.chromium.org/1271423002
Diffstat (limited to 'site/dev/contrib')
| -rw-r--r-- | site/dev/contrib/cqkeywords.md | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/site/dev/contrib/cqkeywords.md b/site/dev/contrib/cqkeywords.md index 50271dd0cc..2616595d19 100644 --- a/site/dev/contrib/cqkeywords.md +++ b/site/dev/contrib/cqkeywords.md @@ -11,7 +11,7 @@ To do a dry run through the CQ please use Rietveld's [dry run](https://groups.go COMMIT=false -The CQ will run through its list of verifiers (reviewer check, trybots, tree check, +The CQ will run through its list of verifiers (reviewer check, trybots, tree check, presubmit check), and will close the issue instead of committing it. NO_DEPENDENCY_CHECKS @@ -25,7 +25,7 @@ depends on another CL that is not yet closed. You can skip this check with this CQ_INCLUDE_TRYBOTS ------------------ -Allows you to add arbitrary trybots to the CQ's list of default trybots. +Allows you to add arbitrary trybots to the CQ's list of default trybots. The CQ will block till these tryjobs pass just like the default list of tryjobs. This is the format of the values of this keyword: @@ -41,7 +41,7 @@ Here are some real world examples: CQ_EXCLUDE_TRYBOTS ------------------ -Allows you to remove trybots from the CQ's list of default trybots. Should only be +Allows you to remove trybots from the CQ's list of default trybots. Should only be used when particular builders are failing for reasons unrelated to your code changes. This is the format of the values of this keyword: @@ -71,12 +71,12 @@ Here are some real world examples: CQ_TRYBOTS=tryserver.skia:Build-Win7-VS2010-x86-Debug-Trybot, Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot, Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot, - Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot,Build-Mac10.8-Clang-x86_64-Release-Trybot + Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot,Build-Mac10.8-Clang-x86_64-Release-Trybot TBR --- -If you are a Skia committer and cannot wait for a review, +If you are a Skia committer and cannot wait for a review, then you can include the TBR keyword in your CL's description. Example: @@ -86,20 +86,20 @@ Example: NOTREECHECKS ------------ -If you want to skip the tree status checks, to make the CQ commit a CL even if the tree is closed, +If you want to skip the tree status checks, to make the CQ commit a CL even if the tree is closed, you can add the following line to the CL description: NOTREECHECKS=true -This is discouraged, since the tree is closed for a reason. However, in rare cases this is acceptable, +This is discouraged, since the tree is closed for a reason. However, in rare cases this is acceptable, primarily to fix build breakages (i.e., your CL will help in reopening the tree). -NOPRESUBMIT +CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot (née NOPRESUBMIT) ----------- If you want to skip the presubmit checks, add the following line to the CL description: - NOPRESUBMIT=true + CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot NOTRY ----- |