diff options
author | 2017-03-22 12:05:03 -0400 | |
---|---|---|
committer | 2017-03-22 16:06:18 +0000 | |
commit | d3b65972aad96453ff4510caa3e25a2b847c6d1e (patch) | |
tree | b79341c2266afe3b529aa1f4cd80c97b9a9e71ae /samplecode | |
parent | 30a38ff737c61799b0f36d2e6ba412f7e612f617 (diff) |
Mark overridden destructors with 'override' and remove 'virtual'
This silences a new warning in clang 5.0
Change-Id: Ieb5b75a6ffed60107c3fd16075d2ecfd515b55e8
Reviewed-on: https://skia-review.googlesource.com/10006
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'samplecode')
-rw-r--r-- | samplecode/GMSampleView.h | 2 | ||||
-rw-r--r-- | samplecode/OverView.cpp | 2 | ||||
-rw-r--r-- | samplecode/SampleApp.cpp | 2 | ||||
-rw-r--r-- | samplecode/SampleApp.h | 2 | ||||
-rw-r--r-- | samplecode/SamplePathText.cpp | 4 | ||||
-rw-r--r-- | samplecode/SampleSVGFile.cpp | 2 |
6 files changed, 7 insertions, 7 deletions
diff --git a/samplecode/GMSampleView.h b/samplecode/GMSampleView.h index 4d29190230..6424b43d25 100644 --- a/samplecode/GMSampleView.h +++ b/samplecode/GMSampleView.h @@ -18,7 +18,7 @@ private: public: GMSampleView(GM*); - virtual ~GMSampleView(); + ~GMSampleView() override; static SkEvent* NewShowSizeEvt(bool doShowSize); diff --git a/samplecode/OverView.cpp b/samplecode/OverView.cpp index 0cd129e573..62e8c2aa19 100644 --- a/samplecode/OverView.cpp +++ b/samplecode/OverView.cpp @@ -45,7 +45,7 @@ static bool draw_this_name(const SkString& name, const SkString& filter) { class OverView : public SkView { public: OverView(int count, const SkViewFactory* factories[]); - virtual ~OverView(); + ~OverView() override; protected: bool onEvent(const SkEvent&) override; diff --git a/samplecode/SampleApp.cpp b/samplecode/SampleApp.cpp index 79023a0b99..6b9a888651 100644 --- a/samplecode/SampleApp.cpp +++ b/samplecode/SampleApp.cpp @@ -205,7 +205,7 @@ public: fBackend = kNone_BackEndType; } - virtual ~DefaultDeviceManager() { + ~DefaultDeviceManager() override { #if SK_SUPPORT_GPU SkSafeUnref(fCurContext); SkSafeUnref(fCurIntf); diff --git a/samplecode/SampleApp.h b/samplecode/SampleApp.h index 7b0dbf4942..e4c1f38922 100644 --- a/samplecode/SampleApp.h +++ b/samplecode/SampleApp.h @@ -114,7 +114,7 @@ public: }; SampleWindow(void* hwnd, int argc, char** argv, DeviceManager*); - virtual ~SampleWindow(); + ~SampleWindow() override; sk_sp<SkSurface> makeSurface() override { sk_sp<SkSurface> surface; diff --git a/samplecode/SamplePathText.cpp b/samplecode/SamplePathText.cpp index 26ffb9a31c..bb2142ef92 100644 --- a/samplecode/SamplePathText.cpp +++ b/samplecode/SamplePathText.cpp @@ -116,7 +116,7 @@ public: , fBackMatrices(kNumPaths) { } - ~MovingPathText() { + ~MovingPathText() override { fBackgroundAnimationTask.wait(); } @@ -227,7 +227,7 @@ public: : fFrontPaths(kNumPaths) , fBackPaths(kNumPaths) {} - ~WavyPathText() { + ~WavyPathText() override { fBackgroundAnimationTask.wait(); } diff --git a/samplecode/SampleSVGFile.cpp b/samplecode/SampleSVGFile.cpp index efffb20d7a..0be7944f8e 100644 --- a/samplecode/SampleSVGFile.cpp +++ b/samplecode/SampleSVGFile.cpp @@ -20,7 +20,7 @@ class SVGFileView : public SampleView { public: SVGFileView(const SkString& path) : fPath(path), fLabel(SkStringPrintf("[%s]", SkOSPath::Basename(path.c_str()).c_str())) {} - virtual ~SVGFileView() = default; + ~SVGFileView() override = default; protected: void onOnceBeforeDraw() override { |