diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-11-18 16:03:59 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-11-18 16:03:59 +0000 |
| commit | e61a86cfa00ea393ecc4a71fca94e1d476a37ecc (patch) | |
| tree | f6ec6c793f279f8226ea40283e707cf3c716e12b /samplecode/SampleLayers.cpp | |
| parent | 8bf4c0ab7b4acd25566459fc464027c5760d0e5e (diff) | |
Guard against most unintentionally ephemeral SkAutoFoo instantiations.
I think I applied the trick everywhere possible. Limitations:
- can't be used with templated classes
- all constructors and destructors must be defined inline
A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I
deleted them. This change caught the same bugs Cary found in SkPath, plus one
more in SampleApp.
BUG=
R=reed@google.com, caryclark@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/72603005
git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'samplecode/SampleLayers.cpp')
| -rw-r--r-- | samplecode/SampleLayers.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/samplecode/SampleLayers.cpp b/samplecode/SampleLayers.cpp index f72c519faf..483943d5d4 100644 --- a/samplecode/SampleLayers.cpp +++ b/samplecode/SampleLayers.cpp @@ -61,7 +61,7 @@ static void test_fade(SkCanvas* canvas) { SkPaint p; p.setAlpha(0x88); - SkAutoCanvasRestore(canvas, false); + SkAutoCanvasRestore ar2(canvas, false); // create the layers |