diff options
author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-02-21 10:13:32 +0000 |
---|---|---|
committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-02-21 10:13:32 +0000 |
commit | 7c9d0f3104408a64d52b84643f116179022d73bd (patch) | |
tree | 85aa1d482887cfed57315f1ce8f1d928001236ae /samplecode/SampleAll.cpp | |
parent | 0b45dc45d67144421904555ccf53782cc8d9969d (diff) |
Factory methods for heap-allocated SkMaskFilter objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkMaskFilter and its subclasses non-public
and instead provides factory methods for creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.
BUG=skia:2187
R=scroggo@google.com, mtklein@google.com, reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/173633003
git-svn-id: http://skia.googlecode.com/svn/trunk@13527 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'samplecode/SampleAll.cpp')
-rw-r--r-- | samplecode/SampleAll.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/samplecode/SampleAll.cpp b/samplecode/SampleAll.cpp index bb5aadd1d8..eb988f1fbf 100644 --- a/samplecode/SampleAll.cpp +++ b/samplecode/SampleAll.cpp @@ -388,7 +388,7 @@ protected: light.fAmbient = 0x48; light.fSpecular = 0x80; SkScalar sigma = SkBlurMask::ConvertRadiusToSigma(SkIntToScalar(12)/5); - SkEmbossMaskFilter* embossFilter = new SkEmbossMaskFilter(sigma, light); + SkEmbossMaskFilter* embossFilter = SkEmbossMaskFilter::Create(sigma, light); SkXfermode* xfermode = SkXfermode::Create(SkXfermode::kXor_Mode); SkColorFilter* lightingFilter = SkColorFilter::CreateLightingFilter( |