diff options
author | 2012-03-29 15:18:04 +0000 | |
---|---|---|
committer | 2012-03-29 15:18:04 +0000 | |
commit | 54924243c1b65b3ee6d8fa064b50a9b1bb2a19a5 (patch) | |
tree | e27f07f67a7d5ecd2149ced9d389c1a078ebb656 /samplecode/SampleAll.cpp | |
parent | 5a64e58ebb19228828eaa800822afa4d9510ccf2 (diff) |
Cleanup code related to SkFlattenable::flatten()
The following changes were made by this CL:
1. Make flatten() a protected method as callers should use
SkFlattenableWriteBuffer to flatten an object
2. Make flatten a const method (including subclasses)
3. Mark subclass implementation of flatten with SK_OVERRIDE
4. Ensure overridden flatten impls call their parent
5. Remove no-op implementations of flatten from subclasses
Additionally, if necessary the unflattening constructor was
also moved to the protected section of the subclasses
header if it was not already there.
git-svn-id: http://skia.googlecode.com/svn/trunk@3540 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'samplecode/SampleAll.cpp')
-rw-r--r-- | samplecode/SampleAll.cpp | 25 |
1 files changed, 12 insertions, 13 deletions
diff --git a/samplecode/SampleAll.cpp b/samplecode/SampleAll.cpp index 8d2157fbf0..5b12e68a99 100644 --- a/samplecode/SampleAll.cpp +++ b/samplecode/SampleAll.cpp @@ -159,11 +159,6 @@ public: Dot2DPathEffect(SkScalar radius, const SkMatrix& matrix) : Sk2DPathEffect(matrix), fRadius(radius) {} - virtual void flatten(SkFlattenableWriteBuffer& buffer) { - this->INHERITED::flatten(buffer); - - buffer.writeScalar(fRadius); - } SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(Dot2DPathEffect) protected: @@ -171,9 +166,14 @@ protected: dst->addCircle(loc.fX, loc.fY, fRadius); } - Dot2DPathEffect(SkFlattenableReadBuffer& buffer) : Sk2DPathEffect(buffer) { + Dot2DPathEffect(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) { fRadius = buffer.readScalar(); } + virtual void flatten(SkFlattenableWriteBuffer& buffer) const SK_OVERRIDE { + this->INHERITED::flatten(buffer); + buffer.writeScalar(fRadius); + } + private: SkScalar fRadius; @@ -218,11 +218,6 @@ public: return false; } - virtual void flatten(SkFlattenableWriteBuffer& buffer) { - this->INHERITED::flatten(buffer); - buffer.writeScalar(fWidth); - } - SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(Line2DPathEffect) protected: @@ -241,10 +236,14 @@ protected: } } - Line2DPathEffect(SkFlattenableReadBuffer& buffer) : Sk2DPathEffect(buffer) { + Line2DPathEffect(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) { fWidth = buffer.readScalar(); } - + virtual void flatten(SkFlattenableWriteBuffer& buffer) const SK_OVERRIDE { + this->INHERITED::flatten(buffer); + buffer.writeScalar(fWidth); + } + private: SkScalar fWidth; |