diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-03-28 18:05:29 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-03-28 18:05:29 +0000 |
| commit | d643a90ee248d22ec8260512812dee6d463de555 (patch) | |
| tree | 3260334e7d03e5f509ff4a5546457f17e4f3d029 /platform_tools | |
| parent | 972f9cd7a063d0544f8c919fd12b9a3adbd12b24 (diff) | |
Revert of ARM Skia NEON patches - 35 - First AArch64 support (https://codereview.chromium.org/143423004/)
Reason for revert:
GYP's failing on most (all?) bots.
Original issue's description:
> ARM Skia NEON patches - 35 - First AArch64 support
>
> Aarch64 support
>
> This change contains the necessary modifications to have Skia build and
> run properly on an ARMv8 processor in aarch64 execution state.
>
> Here's a list of the changes:
>
> - add an arm64 target to the build system + SK_CPU_ARM64 flag
>
> - MatrixTest was failing when built in Release mode. Fused MAC
> instructions were generated which made some intermediate results
> more accurate. As the test relies on result comparison, the more
> precise results when compared to others led to a gap bigger than
> what was tolerated. As I don't know if some actual skia code relies
> on results being comparable, I've disabled fused MAC instruction
> with -ffp-contract=off for arm64.
>
> - Modify include/core/SkOnce.h to have barriers work.
>
> - SK_CPU_ARM64 implies SK_ARM_NEON_MODE_ALWAYS.
>
> - use existing Xfermode optimisations with modifications that can be
> removed in the future when toolchains are ready. Also save a few
> instructions is two Xfermodes (will apply to ARM too).
>
> - use existing SkBoxBlur and SkMorphology optimisations.
>
> - use existing SkBlitMask optimisations
>
> - use existing BitmapProcState and Convolution optimisations.
>
> Future changes will include:
>
> - Blitters (only partialy merged upstream)
>
> - SkUtils (there's little value in sending asm optimisations without
> having them benchmarked on real hardware).
>
> Signed-off-by: Kevin PETIT <kevin.petit@arm.com>
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13980
R=djsollen@google.com, reed@google.com, halcanary@google.com, kevin.petit@arm.com
TBR=djsollen@google.com, halcanary@google.com, kevin.petit@arm.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/216113005
git-svn-id: http://skia.googlecode.com/svn/trunk@13983 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'platform_tools')
| -rwxr-xr-x | platform_tools/barelinux/bin/arm64_make | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/platform_tools/barelinux/bin/arm64_make b/platform_tools/barelinux/bin/arm64_make index 96f16557e6..587181e927 100755 --- a/platform_tools/barelinux/bin/arm64_make +++ b/platform_tools/barelinux/bin/arm64_make @@ -7,7 +7,7 @@ usage() { cat >&2 <<EOF -arm64_make - this script builds a AArch64 version of skia that +arm64_make - this script builds a ARMv7 Aarch64 version of skia that does not depend on external libraries, perfect for putting in an embedded system running Linux. @@ -45,7 +45,12 @@ done export GYP_DEFINES="${GYP_DEFINES} \ skia_gpu=0 \ - skia_arch_type=arm64 \ + skia_arch_type=arm \ + skia_arch_width=64 \ + armv7=1 \ + armv8=1 \ + arm_neon=0 \ + arm_thumb=0 \ " "$(dirname "$0")/barelinux_make" -t "$BUILD_TYPE" |