aboutsummaryrefslogtreecommitdiffhomepage
path: root/platform_tools/ios
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@google.com>2015-04-21 08:09:30 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-04-21 08:09:30 -0700
commita4a0aeb74808a0860f3e94588d0ceb0da9fed386 (patch)
treedf261cb8e23161abffe763002dfa0d650bbcc357 /platform_tools/ios
parent8672f4dffa4b298d4cabee6151590ae885d47263 (diff)
Revert of Convert Color32 code to perfect blend. (patchset #6 id:100001 of https://codereview.chromium.org/1098913002/)
Reason for revert: Xfermode_SrcOver not looking encouraging. Up to 50% regressions. https://perf.skia.org/#3242 Original issue's description: > Convert Color32 code to perfect blend. > > Before we commit to blend_256_round_alt, let's make sure blend_perfect is > really slower in practice (i.e. regresses on perf.skia.org). > > blend_perfect is really the most desirable algorithm if we can afford it. Not > only is it correct, but it's easy to think about and break into correct pieces: > for instance, its div255() doesn't require any coordination with the multiply. > > This looks like a 30% hit according to microbenches. That said, microbenches > said my previous change would be a 20-25% perf improvement, but it didn't end > up showing a significant effect at a high level. > > As for correctness, I see a bunch of off-by-1 compared to blend_256_round_alt > (exactly what we'd expect), and one off-by-3 in a GM that looks like it has a > bunch of overdraw. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/61221e7f87a99765b0e034020e06bb018e2a08c2 TBR=reed@google.com,fmalita@chromium.org,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1083923006
Diffstat (limited to 'platform_tools/ios')
0 files changed, 0 insertions, 0 deletions