diff options
| author |  Andrii Shyshkalov <tandrii@google.com> | 2017-02-20 10:34:35 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-02-22 16:06:01 +0000 |
| commit | 1f5e139ffd6e62b24e2458a56d4b125fd3151881 (patch) | |
| tree | 0d15c258c666524738dd0235a246ebfa7465cc22 /infra | |
| parent | d2743ea50c43ff4cadbc3fc634449d3ab1685701 (diff) | |
Reland "CQ config: add gerrit CQAbility verifier."
This reverts commit 02241e976b34c8bc4b2d4add2f0c881d8a8d2bc1.
Reason for revert: cq proto has been rolled to depot_tools.
Original change's description:
> Revert "CQ config: add gerrit CQAbility verifier."
>
> This reverts commit 04628221324eb2e5b329a8fd9c69196ea9acb43c.
>
> Reason for revert: Lets revert until the proto is rolled into Skia.
>
> Original change's description:
> > CQ config: add gerrit CQAbility verifier.
> >
> > Goal is to ensure that unreviewed and untrusted code isn't sent through
> > CQ to try bots, by accident or through malicious intent.
> >
> > R=​rmistry@google.com
> > BUG=chromium:692613
> > NOTRY=True
> >
> > Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0
> > Reviewed-on: https://skia-review.googlesource.com/8620
> > Reviewed-by: Ravi Mistry <rmistry@google.com>
> > Commit-Queue: Ravi Mistry <rmistry@google.com>
> >
>
> TBR=rmistry@google.com,reviews@skia.org,tandrii@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:692613
>
> Change-Id: I6d4b821b2a02ef3e097cf68cd8ebfb2b51d4d165
> Reviewed-on: https://skia-review.googlesource.com/8663
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Commit-Queue: Ravi Mistry <rmistry@google.com>
>
R=rmistry@google.com,reviews@skia.org,tandrii@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=chromium:692613
Change-Id: Icefcd69b4608e5294f358de66a9ce014c9950ede
Reviewed-on: https://skia-review.googlesource.com/8740
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Diffstat (limited to 'infra')
| -rw-r--r-- | infra/branch-config/cq.cfg | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/infra/branch-config/cq.cfg b/infra/branch-config/cq.cfg index a605f129ee..8a2ffe9421 100644 --- a/infra/branch-config/cq.cfg +++ b/infra/branch-config/cq.cfg @@ -22,6 +22,10 @@ verifiers { no_lgtm_msg: "No LGTM from a valid reviewer yet. Please ask for an LGTM " "from a\nfull Skia committer" } + gerrit_cq_ability { + committer_list: "project-skia-committers" + dry_run_access_list: "project-skia-tryjob-access" + } tree_status { tree_status_url: "https://skia-tree-status.appspot.com" |