aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipes
diff options
context:
space:
mode:
authorGravatar Ben Wagner <benjaminwagner@google.com>2018-06-19 10:34:32 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-06-19 17:29:15 +0000
commit96aa535b782f31df0f063213c2958acba32a808d (patch)
treeb31c2ac0ba3c7e84f648fec46b4d2e29267b78d8 /infra/bots/recipes
parentba61029c5b4939fc33a8cd5db3e7e19c6742cc4b (diff)
Remove .bat and .exe from commands where possible.
We expect .BAT and .EXE to be on PATHEXT. Also, although Python CreateProcess doesn't honor PATHEXT, it will try .EXE. This allows most commands to be platform-independent, and also resolves the issue with the cpython package not including python.bat. No-Tree-Checks: true Docs-Preview: https://skia.org/?cl=135626 Bug: chromium:852581 Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397 Reviewed-on: https://skia-review.googlesource.com/135626 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
Diffstat (limited to 'infra/bots/recipes')
-rw-r--r--infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json4
1 files changed, 2 insertions, 2 deletions
diff --git a/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json b/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json
index 93f86d69b2..6f5bdee0e3 100644
--- a/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json
+++ b/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json
@@ -138,7 +138,7 @@
},
{
"cmd": [
- "[START_DIR]/cache/work/skia/bin/gn.exe",
+ "[START_DIR]/cache/work/skia/bin/gn",
"gen",
"[START_DIR]/cache/work/skia/out/Build-Win-Clang-x86-Debug/Debug",
"--args=cc=\"clang\" clang_win=\"[START_DIR]/clang_win\" cxx=\"clang++\" extra_cflags=[\"-O1\", \"-DDUMMY_clang_win_version=42\"] target_cpu=\"x86\" win_sdk=\"[START_DIR]/t/depot_tools/win_toolchain/vs_files/5454e45bf3764c03d3fc1024b3bf5bc41e3ab62c/win_sdk\" win_vc=\"[START_DIR]/t/depot_tools/win_toolchain/vs_files/5454e45bf3764c03d3fc1024b3bf5bc41e3ab62c/VC\""
@@ -152,7 +152,7 @@
},
{
"cmd": [
- "ninja.exe",
+ "ninja",
"-k",
"0",
"-C",