diff options
author | 2018-03-14 17:20:08 +0000 | |
---|---|---|
committer | 2018-03-14 17:20:13 +0000 | |
commit | 2f2419b936150e24ca1aea891ba405c8ea8ebdc7 (patch) | |
tree | ecf761d6a5f941a925c32e994326920a1b2de0a2 /infra/bots/recipes | |
parent | e462b80d966f006c5164f1cad90f79d916b61a6b (diff) |
Revert "Switch Win Exceptions Build to Clang."
This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551.
Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093
Original change's description:
> Switch Win Exceptions Build to Clang.
>
> No-Try: true
> Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431
> Reviewed-on: https://skia-review.googlesource.com/113673
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
TBR=mtklein@google.com,benjaminwagner@google.com
Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/114420
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Diffstat (limited to 'infra/bots/recipes')
-rw-r--r-- | infra/bots/recipes/compile.expected/Build-Win-MSVC-x86-Debug-Exceptions.json (renamed from infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug-Exceptions.json) | 20 | ||||
-rw-r--r-- | infra/bots/recipes/compile.py | 2 |
2 files changed, 8 insertions, 14 deletions
diff --git a/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug-Exceptions.json b/infra/bots/recipes/compile.expected/Build-Win-MSVC-x86-Debug-Exceptions.json index 38e417f844..1d8d3e1c3c 100644 --- a/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug-Exceptions.json +++ b/infra/bots/recipes/compile.expected/Build-Win-MSVC-x86-Debug-Exceptions.json @@ -102,11 +102,9 @@ "cwd": "[CUSTOM_C:\\_B_WORK]\\skia", "env": { "BUILDTYPE": "Debug", - "CC": "/usr/bin/clang", "CHROME_HEADLESS": "1", - "CXX": "/usr/bin/clang++", "PATH": "<PATH>;RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-Clang-x86-Debug-Exceptions" + "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Debug-Exceptions" }, "infra_step": true, "name": "fetch-gn" @@ -115,17 +113,15 @@ "cmd": [ "[CUSTOM_C:\\_B_WORK]\\skia\\bin\\gn.exe", "gen", - "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-Clang-x86-Debug-Exceptions\\Debug", - "--args=cc=\"clang\" clang_win=\"[START_DIR]\\clang_win\" cxx=\"clang++\" extra_cflags=[\"-O1\", \"/EHsc\"] target_cpu=\"x86\" win_sdk=\"[START_DIR]\\t\\depot_tools\\win_toolchain\\vs_files\\a9e1098bba66d2acccc377d5ee81265910f29272/win_sdk\" win_vc=\"[START_DIR]\\t\\depot_tools\\win_toolchain\\vs_files\\a9e1098bba66d2acccc377d5ee81265910f29272/VC\"" + "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Debug-Exceptions\\Debug", + "--args=extra_cflags=[\"/EHsc\"] target_cpu=\"x86\" win_sdk=\"[START_DIR]\\t\\depot_tools\\win_toolchain\\vs_files\\a9e1098bba66d2acccc377d5ee81265910f29272/win_sdk\" win_vc=\"[START_DIR]\\t\\depot_tools\\win_toolchain\\vs_files\\a9e1098bba66d2acccc377d5ee81265910f29272/VC\"" ], "cwd": "[CUSTOM_C:\\_B_WORK]\\skia", "env": { "BUILDTYPE": "Debug", - "CC": "/usr/bin/clang", "CHROME_HEADLESS": "1", - "CXX": "/usr/bin/clang++", "PATH": "<PATH>;RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-Clang-x86-Debug-Exceptions" + "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Debug-Exceptions" }, "name": "gn gen" }, @@ -135,16 +131,14 @@ "-k", "0", "-C", - "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-Clang-x86-Debug-Exceptions\\Debug" + "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Debug-Exceptions\\Debug" ], "cwd": "[CUSTOM_C:\\_B_WORK]\\skia", "env": { "BUILDTYPE": "Debug", - "CC": "/usr/bin/clang", "CHROME_HEADLESS": "1", - "CXX": "/usr/bin/clang++", "PATH": "<PATH>;RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-Clang-x86-Debug-Exceptions" + "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Debug-Exceptions" }, "name": "ninja" }, @@ -153,7 +147,7 @@ "python", "-u", "import errno\nimport glob\nimport os\nimport shutil\nimport sys\n\nsrc = sys.argv[1]\ndst = sys.argv[2]\nbuild_products_whitelist = ['bookmaker', 'dm', 'dm.exe', 'dm.app', 'nanobench.app', 'get_images_from_skps', 'get_images_from_skps.exe', 'nanobench', 'nanobench.exe', 'skpbench', '*.so', '*.dll', '*.dylib', 'skia_launcher', 'skiaserve', 'lib/*.so', 'run_testlab', 'skqp-universal-debug.apk', 'whitelist_devices.json']\n\ntry:\n os.makedirs(dst)\nexcept OSError as e:\n if e.errno != errno.EEXIST:\n raise\n\nfor pattern in build_products_whitelist:\n path = os.path.join(src, pattern)\n for f in glob.glob(path):\n dst_path = os.path.join(dst, os.path.relpath(f, src))\n if not os.path.isdir(os.path.dirname(dst_path)):\n os.makedirs(os.path.dirname(dst_path))\n print 'Copying build product %s to %s' % (f, dst_path)\n shutil.move(f, dst_path)\n", - "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-Clang-x86-Debug-Exceptions\\Debug", + "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Debug-Exceptions\\Debug", "[CUSTOM_[SWARM_OUT_DIR]]\\out\\Debug" ], "infra_step": true, diff --git a/infra/bots/recipes/compile.py b/infra/bots/recipes/compile.py index 114db7259e..1ad4d7f12a 100644 --- a/infra/bots/recipes/compile.py +++ b/infra/bots/recipes/compile.py @@ -109,10 +109,10 @@ TEST_BUILDERS = [ 'Build-Mac-Clang-x86_64-Debug-CommandBuffer', 'Build-Mac-Clang-x86_64-Release', 'Build-Win-Clang-arm64-Release-Android', - 'Build-Win-Clang-x86-Debug-Exceptions', 'Build-Win-Clang-x86_64-Release-Vulkan', 'Build-Win-MSVC-x86-Debug', 'Build-Win-MSVC-x86-Debug-ANGLE', + 'Build-Win-MSVC-x86-Debug-Exceptions', 'Build-Win-MSVC-x86-Release-GDI', ] |