diff options
| author |  Kevin Lubick <kjlubick@google.com> | 2017-11-30 08:35:29 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-11-30 14:13:22 +0000 |
| commit | 1c8092ac64dc4d9fd140d7fd46fa52163fe26569 (patch) | |
| tree | 199b0a34aadd3c993059af7a5726a0bf6d792ed4 /infra/bots/recipes/perf.py | |
| parent | 8816b93134db2fecdfd690fd26967468f6c814b9 (diff) | |
Make cpu scaling more robust
Some bots, especially the Nexus 7s, seemed to occasionally
fail when setting the CPU frequency. I was unable to
repro this behavior, so this is a shotgun approach.
We add a 5 second delay between setting and checking,
checking frequency using scaling_cur_freq instead of
scaling_setspeed, set the min_freq as well as max_freq,
and retry up to 3 times if setting cpu frequency fails.
NOTRY=true
Bug: skia:
Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2
Reviewed-on: https://skia-review.googlesource.com/78140
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Diffstat (limited to 'infra/bots/recipes/perf.py')
| -rw-r--r-- | infra/bots/recipes/perf.py | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/infra/bots/recipes/perf.py b/infra/bots/recipes/perf.py index cc414efed0..2362ea29a5 100644 --- a/infra/bots/recipes/perf.py +++ b/infra/bots/recipes/perf.py @@ -457,7 +457,7 @@ def GenTests(api): ) yield ( - api.test('cpu_scale_failed') + + api.test('cpu_scale_failed_once') + api.properties(buildername=builder, revision='abc123', path_config='kitchen', @@ -474,3 +474,24 @@ def GenTests(api): ) + api.step_data('Scale CPU to 0.600000', retcode=1) ) + + yield ( + api.test('cpu_scale_failed') + + api.properties(buildername=builder, + revision='abc123', + path_config='kitchen', + swarm_out_dir='[SWARM_OUT_DIR]') + + api.path.exists( + api.path['start_dir'].join('skia'), + api.path['start_dir'].join('skia', 'infra', 'bots', 'assets', + 'skimage', 'VERSION'), + api.path['start_dir'].join('skia', 'infra', 'bots', 'assets', + 'skp', 'VERSION'), + api.path['start_dir'].join('skia', 'infra', 'bots', 'assets', + 'svg', 'VERSION'), + api.path['start_dir'].join('tmp', 'uninteresting_hashes.txt') + ) + + api.step_data('Scale CPU to 0.600000', retcode=1)+ + api.step_data('Scale CPU to 0.600000 (attempt 2)', retcode=1)+ + api.step_data('Scale CPU to 0.600000 (attempt 3)', retcode=1) + ) |