diff options
| author |  Kevin Lubick <kjlubick@google.com> | 2017-12-12 07:55:43 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-12-12 13:26:39 +0000 |
| commit | 3250a487ea978ecabcc7b32c5bd1eb3c0581b7ad (patch) | |
| tree | 15c640a00a67b8cd74a4660334752afd6c706aa4 /infra/bots/recipe_modules/flavor | |
| parent | f1585aabeb23cf770c62dd9a1147df885f918671 (diff) | |
Search more for stacktrace to symbolize
If the stacktrace wasn't in the last 200 lines, we couldn't
find and symbolize it.
https://chromium-swarm.appspot.com/task?id=3a5e86a9d0e04e10&refresh=10
We increase the window to 500 lines to account for large memory maps.
Bug: skia:7397
NOTRY=true
Change-Id: Ic8583e383663a9beb62a32e90a5bd5d73d7446a7
Reviewed-on: https://skia-review.googlesource.com/83540
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Diffstat (limited to 'infra/bots/recipe_modules/flavor')
| -rwxr-xr-x | infra/bots/recipe_modules/flavor/resources/symbolize_stack_trace.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/infra/bots/recipe_modules/flavor/resources/symbolize_stack_trace.py b/infra/bots/recipe_modules/flavor/resources/symbolize_stack_trace.py index 59e1e39e08..f490a060cf 100755 --- a/infra/bots/recipe_modules/flavor/resources/symbolize_stack_trace.py +++ b/infra/bots/recipe_modules/flavor/resources/symbolize_stack_trace.py @@ -29,7 +29,7 @@ import sys # about the logs of previous steps without using a wrapper like this. def main(basedir, cmd): - logs = collections.deque(maxlen=200) + logs = collections.deque(maxlen=500) proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) @@ -47,7 +47,7 @@ def main(basedir, cmd): # doesn't have that. So, we capture both addresses and prefer using the first # over the second, unless the first is blank or invalid. Relative offsets # like abort+0x16a are ignored. - stack_line = r'^(?P<path>.+)\(\+?(?P<addr>.*)\) \[(?P<addr2>.+)\]' + stack_line = r'^(?P<path>.+)\(\+?(?P<addr>.*)\) ?\[(?P<addr2>.+)\]' # After performing addr2line, the result can be something obnoxious like: # foo(bar) at /b/s/w/a39kd/Skia/out/Clang/../../src/gpu/Frobulator.cpp:13 # The extra_path strips off the not-useful prefix and leaves just the |