diff options
author | 2018-04-26 18:19:25 -0400 | |
---|---|---|
committer | 2018-04-26 22:21:04 +0000 | |
commit | 01d3eb64e7b11b22cf206758f01b06a7ae0bbb20 (patch) | |
tree | 2c53c65e62df6387cf77b1a33a447a47024e1b3f /infra/bots/recipe_modules/core | |
parent | bf134d2283570786984f2c1630abbbc2c2e1bf09 (diff) |
Revert "[recipes] Use named caches for git and workdirs"
This reverts commit e8615f969e92009551b70c85d1913202390e0b0d.
Reason for revert: Causing CommandBuffer builds to time out
Original change's description:
> [recipes] Use named caches for git and workdirs
>
> Bug: skia:
> Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
> Reviewed-on: https://skia-review.googlesource.com/123929
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
----------------
Revert "[infra] Fix missing cache for Bookmaker"
This reverts commit d19f039a16cc4ed29dc6f0ef7100125819ca291d.
Reason for revert: Need to revert https://skia-review.googlesource.com/123929
Original change's description:
> [infra] Fix missing cache for Bookmaker
>
> Bug: skia:
> Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
> Reviewed-on: https://skia-review.googlesource.com/124052
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
----------------
Revert "Fix missing/duplicate named caches"
This reverts commit 0820a6fb697be598b41b65c7645659e216b30bc5.
Reason for revert: Need to revert https://skia-review.googlesource.com/123929
Original change's description:
> Fix missing/duplicate named caches
>
> Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
>
> No-Try: true
> Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
> Reviewed-on: https://skia-review.googlesource.com/124180
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>
----------------
TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com
Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/124203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Diffstat (limited to 'infra/bots/recipe_modules/core')
7 files changed, 43 insertions, 43 deletions
diff --git a/infra/bots/recipe_modules/core/examples/full.expected/Housekeeper-Weekly-RecreateSKPs.json b/infra/bots/recipe_modules/core/examples/full.expected/Housekeeper-Weekly-RecreateSKPs.json index cf2c43fcb2..a2967213c3 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/Housekeeper-Weekly-RecreateSKPs.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/Housekeeper-Weekly-RecreateSKPs.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work" + "[CUSTOM_/_B_WORK]" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/.gclient_entries" + "[CUSTOM_/_B_WORK]/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/.gclient_entries" + "name": "remove [CUSTOM_/_B_WORK]/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}, {'deps_file': '.DEPS.git', 'managed': False, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]", + "cache_dir = '[CUSTOM_/_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}, {'deps_file': '.DEPS.git', 'managed': False, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]", "--patch_root", "skia", "--revision_mapping_file", "{\"got_revision\": \"skia\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_/_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--output_json", @@ -49,7 +49,7 @@ "--revision", "src@origin/lkcr" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_/_B_WORK]", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" @@ -103,7 +103,7 @@ "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py", "runhooks" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_/_B_WORK]", "env": { "CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1", "DEPOT_TOOLS_UPDATE": "0", diff --git a/infra/bots/recipe_modules/core/examples/full.expected/cross_repo_trybot.json b/infra/bots/recipe_modules/core/examples/full.expected/cross_repo_trybot.json index 4399b6cde2..af1d2a63b8 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/cross_repo_trybot.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/cross_repo_trybot.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work" + "[CUSTOM_/_B_WORK]" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/.gclient_entries" + "[CUSTOM_/_B_WORK]/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/.gclient_entries" + "name": "remove [CUSTOM_/_B_WORK]/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'parent_repo', 'url': 'https://skia.googlesource.com/parent_repo.git'}]", + "cache_dir = '[CUSTOM_/_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'parent_repo', 'url': 'https://skia.googlesource.com/parent_repo.git'}]", "--patch_root", "skia", "--revision_mapping_file", "{\"got_revision\": \"parent_repo\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_/_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--gerrit_repo", @@ -51,7 +51,7 @@ "--revision", "parent_repo@abc123" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_/_B_WORK]", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" diff --git a/infra/bots/recipe_modules/core/examples/full.expected/flutter_trybot.json b/infra/bots/recipe_modules/core/examples/full.expected/flutter_trybot.json index c73455d175..b41ff52e47 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/flutter_trybot.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/flutter_trybot.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work/flutter" + "[CUSTOM_/_B_WORK]/flutter" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/flutter/.gclient_entries" + "[CUSTOM_/_B_WORK]/flutter/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/flutter/.gclient_entries" + "name": "remove [CUSTOM_/_B_WORK]/flutter/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src/flutter', 'url': 'https://github.com/flutter/engine.git'}]\ntarget_os = ['android']", + "cache_dir = '[CUSTOM_/_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src/flutter', 'url': 'https://github.com/flutter/engine.git'}]\ntarget_os = ['android']", "--patch_root", "src/third_party/skia", "--revision_mapping_file", "{\"got_flutter_revision\": \"src/flutter\", \"got_revision\": \"src/third_party/skia\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_/_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--gerrit_repo", @@ -53,7 +53,7 @@ "--revision", "src/third_party/skia@abc123" ], - "cwd": "[START_DIR]/cache/work/flutter", + "cwd": "[CUSTOM_/_B_WORK]/flutter", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" diff --git a/infra/bots/recipe_modules/core/examples/full.expected/parent_revision.json b/infra/bots/recipe_modules/core/examples/full.expected/parent_revision.json index ffce3b2ee9..162d5d2f2b 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/parent_revision.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/parent_revision.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work" + "[CUSTOM_C:\\_B_WORK]" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/.gclient_entries" + "[CUSTOM_C:\\_B_WORK]/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/.gclient_entries" + "name": "remove [CUSTOM_C:\\_B_WORK]/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]", + "cache_dir = '[CUSTOM_C:\\\\_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]", "--patch_root", "skia", "--revision_mapping_file", "{\"got_revision\": \"skia\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_C:\\_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--output_json", @@ -47,7 +47,7 @@ "--revision", "skia@abc123^" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_C:\\_B_WORK]", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" diff --git a/infra/bots/recipe_modules/core/examples/full.expected/parent_revision_trybot.json b/infra/bots/recipe_modules/core/examples/full.expected/parent_revision_trybot.json index 2a1eb4cb64..8be1f734d4 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/parent_revision_trybot.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/parent_revision_trybot.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work" + "[CUSTOM_C:\\_B_WORK]" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/.gclient_entries" + "[CUSTOM_C:\\_B_WORK]/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/.gclient_entries" + "name": "remove [CUSTOM_C:\\_B_WORK]/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]", + "cache_dir = '[CUSTOM_C:\\\\_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]", "--patch_root", "skia", "--revision_mapping_file", "{\"got_revision\": \"skia\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_C:\\_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--output_json", @@ -47,7 +47,7 @@ "--revision", "skia@abc123" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_C:\\_B_WORK]", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" diff --git a/infra/bots/recipe_modules/core/examples/full.expected/pdfium_trybot.json b/infra/bots/recipe_modules/core/examples/full.expected/pdfium_trybot.json index fe3983f59c..03aed27295 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/pdfium_trybot.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/pdfium_trybot.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work" + "[CUSTOM_/_B_WORK]" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/.gclient_entries" + "[CUSTOM_/_B_WORK]/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/.gclient_entries" + "name": "remove [CUSTOM_/_B_WORK]/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'pdfium', 'url': 'https://pdfium.googlesource.com/pdfium.git'}]", + "cache_dir = '[CUSTOM_/_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'pdfium', 'url': 'https://pdfium.googlesource.com/pdfium.git'}]", "--patch_root", "pdfium/third_party/skia", "--revision_mapping_file", "{\"got_pdfium_revision\": \"pdfium\", \"got_revision\": \"pdfium/third_party/skia\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_/_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--gerrit_repo", @@ -53,7 +53,7 @@ "--revision", "pdfium/third_party/skia@abc123" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_/_B_WORK]", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" diff --git a/infra/bots/recipe_modules/core/examples/full.expected/test.json b/infra/bots/recipe_modules/core/examples/full.expected/test.json index ef0d4965bc..82df2360ab 100644 --- a/infra/bots/recipe_modules/core/examples/full.expected/test.json +++ b/infra/bots/recipe_modules/core/examples/full.expected/test.json @@ -9,7 +9,7 @@ "ensure-directory", "--mode", "0777", - "[START_DIR]/cache/work" + "[CUSTOM_C:\\_B_WORK]" ], "infra_step": true, "name": "makedirs checkout_path" @@ -22,10 +22,10 @@ "--json-output", "/path/to/tmp/json", "remove", - "[START_DIR]/cache/work/.gclient_entries" + "[CUSTOM_C:\\_B_WORK]/.gclient_entries" ], "infra_step": true, - "name": "remove [START_DIR]/cache/work/.gclient_entries" + "name": "remove [CUSTOM_C:\\_B_WORK]/.gclient_entries" }, { "cmd": [ @@ -33,13 +33,13 @@ "-u", "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py", "--spec-path", - "cache_dir = '[START_DIR]/cache/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]", + "cache_dir = '[CUSTOM_C:\\\\_B_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': False, 'name': 'skia', 'url': 'https://skia.googlesource.com/skia.git'}]", "--patch_root", "skia", "--revision_mapping_file", "{\"got_revision\": \"skia\"}", "--git-cache-dir", - "[START_DIR]/cache/git", + "[CUSTOM_C:\\_B_CACHE]", "--cleanup-dir", "[CLEANUP]/bot_update", "--gerrit_repo", @@ -51,7 +51,7 @@ "--revision", "skia@abc123" ], - "cwd": "[START_DIR]/cache/work", + "cwd": "[CUSTOM_C:\\_B_WORK]", "env_prefixes": { "PATH": [ "RECIPE_PACKAGE_REPO[depot_tools]" |