aboutsummaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorGravatar brianosman <brianosman@google.com>2016-06-16 11:41:44 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2016-06-16 11:41:44 -0700
commitab8241880d09eb1774b4993ca6df048a27b7020c (patch)
treef3c7e4c1873771ee818e0a1c86515a3ea5250d75 /include
parent6a61a875467646f8dbc37cfecf49e12d1f475170 (diff)
Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType (patchset #10 id:180001 of https://codereview.chromium.org/2069173002/ )
Reason for revert: Mac crashes in GrUploadPixmapToTexture Original issue's description: > Lots of progress on switching to SkColorSpace rather than SkColorProfileType > > Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002 > > Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170 TBR=reed@google.com,herb@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2072813002
Diffstat (limited to 'include')
-rw-r--r--include/core/SkBitmap.h1
-rw-r--r--include/core/SkImageInfo.h8
-rw-r--r--include/core/SkPixelRef.h2
-rw-r--r--include/gpu/SkGr.h5
-rw-r--r--include/gpu/SkGrPixelRef.h3
-rw-r--r--include/views/SkWindow.h2
6 files changed, 9 insertions, 12 deletions
diff --git a/include/core/SkBitmap.h b/include/core/SkBitmap.h
index b28eca817e..664686619f 100644
--- a/include/core/SkBitmap.h
+++ b/include/core/SkBitmap.h
@@ -85,7 +85,6 @@ public:
int height() const { return fInfo.height(); }
SkColorType colorType() const { return fInfo.colorType(); }
SkAlphaType alphaType() const { return fInfo.alphaType(); }
- SkColorSpace* colorSpace() const { return fInfo.colorSpace(); }
SkColorProfileType profileType() const { return fInfo.profileType(); }
/**
diff --git a/include/core/SkImageInfo.h b/include/core/SkImageInfo.h
index f7a619f9ea..c0e0be13f9 100644
--- a/include/core/SkImageInfo.h
+++ b/include/core/SkImageInfo.h
@@ -379,14 +379,12 @@ private:
///////////////////////////////////////////////////////////////////////////////
-static inline bool SkColorAndColorSpaceAreGammaCorrect(SkColorType ct, SkColorSpace* cs) {
- // Anything with a color-space attached is gamma-correct, as is F16.
- // To get legacy behavior, you need to ask for non-F16, with a nullptr color space.
- return (cs != nullptr) || kRGBA_F16_SkColorType == ct;
+static inline bool SkColorAndProfileAreGammaCorrect(SkColorType ct, SkColorProfileType pt) {
+ return kSRGB_SkColorProfileType == pt || kRGBA_F16_SkColorType == ct;
}
static inline bool SkImageInfoIsGammaCorrect(const SkImageInfo& info) {
- return SkColorAndColorSpaceAreGammaCorrect(info.colorType(), info.colorSpace());
+ return SkColorAndProfileAreGammaCorrect(info.colorType(), info.profileType());
}
#endif
diff --git a/include/core/SkPixelRef.h b/include/core/SkPixelRef.h
index da85863bdb..90e0de540d 100644
--- a/include/core/SkPixelRef.h
+++ b/include/core/SkPixelRef.h
@@ -248,7 +248,7 @@ public:
* not be created with the given config), or this PixelRef does not support deep
* copies.
*/
- virtual SkPixelRef* deepCopy(SkColorType, SkColorSpace*, const SkIRect* /*subset*/) {
+ virtual SkPixelRef* deepCopy(SkColorType, SkColorProfileType, const SkIRect* /*subset*/) {
return NULL;
}
diff --git a/include/gpu/SkGr.h b/include/gpu/SkGr.h
index c5ba34403f..edfcd6d813 100644
--- a/include/gpu/SkGr.h
+++ b/include/gpu/SkGr.h
@@ -72,11 +72,10 @@ GrTexture* GrRefCachedBitmapTexture(GrContext*, const SkBitmap&, const GrTexture
SkSourceGammaTreatment);
// TODO: Move SkImageInfo2GrPixelConfig to SkGrPriv.h (requires cleanup to SkWindow its subclasses).
-GrPixelConfig SkImageInfo2GrPixelConfig(SkColorType, SkAlphaType, const SkColorSpace*,
- const GrCaps&);
+GrPixelConfig SkImageInfo2GrPixelConfig(SkColorType, SkAlphaType, SkColorProfileType, const GrCaps&);
static inline GrPixelConfig SkImageInfo2GrPixelConfig(const SkImageInfo& info, const GrCaps& caps) {
- return SkImageInfo2GrPixelConfig(info.colorType(), info.alphaType(), info.colorSpace(), caps);
+ return SkImageInfo2GrPixelConfig(info.colorType(), info.alphaType(), info.profileType(), caps);
}
GrTextureParams::FilterMode GrSkFilterQualityToGrFilterMode(SkFilterQuality paintFilterQuality,
diff --git a/include/gpu/SkGrPixelRef.h b/include/gpu/SkGrPixelRef.h
index 2bbe48fa09..b4dbd9d73f 100644
--- a/include/gpu/SkGrPixelRef.h
+++ b/include/gpu/SkGrPixelRef.h
@@ -50,7 +50,8 @@ public:
protected:
// overrides from SkPixelRef
bool onReadPixels(SkBitmap* dst, SkColorType, const SkIRect* subset) override;
- SkPixelRef* deepCopy(SkColorType, SkColorSpace*, const SkIRect* subset) override;
+ SkPixelRef* deepCopy(SkColorType, SkColorProfileType,
+ const SkIRect* subset) override;
void onNotifyPixelsChanged() override;
private:
diff --git a/include/views/SkWindow.h b/include/views/SkWindow.h
index 50774849a6..341046aacc 100644
--- a/include/views/SkWindow.h
+++ b/include/views/SkWindow.h
@@ -52,7 +52,7 @@ public:
void resize(int width, int height);
void resize(const SkImageInfo&);
- void setColorType(SkColorType, sk_sp<SkColorSpace>);
+ void setColorType(SkColorType, SkColorProfileType);
bool isDirty() const { return !fDirtyRgn.isEmpty(); }
bool update(SkIRect* updateArea);