diff options
| author |  Mike Klein <mtklein@google.com> | 2018-02-07 01:58:51 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-02-07 01:58:56 +0000 |
| commit | 9ff8c8c073ba553dc8b22bb9aacc23949292f72f (patch) | |
| tree | 52dfdbab4fb28f2db324d45b6691c7f87c4fdca6 /include | |
| parent | 9ca602ae04a761c7983990942a72a45bdfdb2d7d (diff) | |
Revert "remove SkCanvas::kIsOpaque_SaveLayerFlag"
This reverts commit 9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63.
Reason for revert: still need to update blink_headless in Google3
Original change's description:
> remove SkCanvas::kIsOpaque_SaveLayerFlag
>
> This is a performance-only hint that no one but fuzzers
> is using. It's even explicitly filtered out in Android.
>
> The fuzzers have noticed they can trick us into allocating
> uninitialized memory and treating it as opaque, blending
> uninitialized pixels, etc.
>
> Since no one's using this, we can just kill the bit.
>
> Bug: skia:7566, chromium:808830
>
> Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7
> Reviewed-on: https://skia-review.googlesource.com/104441
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,fmalita@chromium.org,reed@google.com
Change-Id: I10d3c7e5184b9322715a5bfb6a7106292c8876a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7566, chromium:808830
Reviewed-on: https://skia-review.googlesource.com/104781
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/core/SkCanvas.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h index 9ac328291c..0c7bfece80 100644 --- a/include/core/SkCanvas.h +++ b/include/core/SkCanvas.h @@ -605,6 +605,11 @@ public: defining how layer allocated by saveLayer() operates. */ enum { + /** Creates layer without transparency. Flag is ignored if layer SkPaint contains + SkImageFilter or SkColorFilter. + */ + kIsOpaque_SaveLayerFlag = 1 << 0, + /** Creates layer for LCD text. Flag is ignored if layer SkPaint contains SkImageFilter or SkColorFilter. */ |