aboutsummaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorGravatar robertphillips <robertphillips@google.com>2014-06-09 06:25:34 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-06-09 06:25:34 -0700
commit9f1c241e0d8a756fca1ec2dacb565eec83166d5f (patch)
tree77a588bd485fb27de5d4dc81a78624968361f65e /include
parent5713352a64936428d37a721382d021f4a9002172 (diff)
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag
The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer? R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316143003
Diffstat (limited to 'include')
-rw-r--r--include/core/SkPicture.h2
-rw-r--r--include/core/SkPictureRecorder.h5
2 files changed, 4 insertions, 3 deletions
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index fb5e7ffd03..793a2e4793 100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -132,6 +132,7 @@ public:
*/
void clone(SkPicture* pictures, int count) const;
+#ifdef SK_SUPPORT_LEGACY_RECORDING_FLAG
// TODO: kUsePathBoundsForClip_RecordingFlag no longer belongs in
// SkPicture. It should be moved to SkPictureRecorder (or just made
// the default behavior).
@@ -146,6 +147,7 @@ public:
*/
kUsePathBoundsForClip_RecordingFlag = 0x01
};
+#endif
/** Replays the drawing commands on the specified canvas.
@param canvas the canvas receiving the drawing commands.
diff --git a/include/core/SkPictureRecorder.h b/include/core/SkPictureRecorder.h
index d9372d89d0..e9ddcf5958 100644
--- a/include/core/SkPictureRecorder.h
+++ b/include/core/SkPictureRecorder.h
@@ -29,10 +29,9 @@ public:
@param recordFlags optional flags that control recording.
@return the canvas.
*/
- // TODO: allow default parameters once the other beginRecoding entry point is gone
SkCanvas* beginRecording(int width, int height,
- SkBBHFactory* bbhFactory /* = NULL */,
- uint32_t recordFlags /* = 0 */);
+ SkBBHFactory* bbhFactory = NULL,
+ uint32_t recordFlags = 0);
/** Returns the recording canvas if one is active, or NULL if recording is
not active. This does not alter the refcnt on the canvas (if present).