diff options
author | vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2011-06-21 21:19:41 +0000 |
---|---|---|
committer | vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2011-06-21 21:19:41 +0000 |
commit | 73322074658e19ff14591236d9b5485910a2c7b7 (patch) | |
tree | 0240384de4e53b2161916d6439e8252c0d736653 /include/pdf/SkPDFGraphicState.h | |
parent | 7359eae7c6fce8cb88ae28ca7048283b77535db4 (diff) |
Fix some problems detected by coverity.
- Uninitialized class member in GSCanonicalEntry and SkPDFDocument.
- Incorrect sign extension in SkPDFFont.
- Dead code in SkPDFUtils.
CID=16262,16272,16273,16275
Review URL: http://codereview.appspot.com/4659041
git-svn-id: http://skia.googlecode.com/svn/trunk@1668 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'include/pdf/SkPDFGraphicState.h')
-rw-r--r-- | include/pdf/SkPDFGraphicState.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/pdf/SkPDFGraphicState.h b/include/pdf/SkPDFGraphicState.h index 49809a4c03..0bdd6f104e 100644 --- a/include/pdf/SkPDFGraphicState.h +++ b/include/pdf/SkPDFGraphicState.h @@ -86,7 +86,9 @@ private: explicit GSCanonicalEntry(SkPDFGraphicState* gs) : fGraphicState(gs), fPaint(&gs->fPaint) {} - explicit GSCanonicalEntry(const SkPaint* paint) : fPaint(paint) {} + explicit GSCanonicalEntry(const SkPaint* paint) + : fGraphicState(NULL), + fPaint(paint) {} }; // This should be made a hash table if performance is a problem. |