diff options
author | Robert Phillips <robertphillips@google.com> | 2017-06-14 01:43:29 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-06-14 01:43:38 +0000 |
commit | fcd5fddb0264d062a461435618ad54a29ff80fc0 (patch) | |
tree | 3fdf24eff4b5aac832b4aec30ffd1754bbcc7263 /include/gpu | |
parent | 9647637f780d61535ac4daa1ff681d2a71b9620d (diff) |
Revert "Revert "Update skia to use ifdefs for Vulkan code instead of dummy header""
This reverts commit fad9e3f54112ea8c8bb6bb72384f47b9759578f5.
Reason for revert: Can't find the error message anymore (?!?) Let's try again shall we
Original change's description:
> Revert "Update skia to use ifdefs for Vulkan code instead of dummy header"
>
> This reverts commit c0f8e426c59eec6c720b8e1329dcb966cf1b6800.
>
> Reason for revert: Experiment to see if this will unblock the Android roll
>
> Original change's description:
> > Update skia to use ifdefs for Vulkan code instead of dummy header
> >
> > Bug: skia:6721
> > Change-Id: I80a4c9f2acc09c174497f625c50ed12a8bb76505
> > Reviewed-on: https://skia-review.googlesource.com/19547
> > Reviewed-by: Mike Klein <mtklein@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com
>
> Change-Id: Ib51c1672570f2071a17b6fbde692a5174b0358ce
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:6721
> Reviewed-on: https://skia-review.googlesource.com/19724
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
TBR=egdaniel@google.com,mtklein@google.com,bsalomon@google.com,robertphillips@google.com
Change-Id: Iecef7ddcfe31d82938336120a4193525ac6693be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:6721
Reviewed-on: https://skia-review.googlesource.com/19782
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Diffstat (limited to 'include/gpu')
-rw-r--r-- | include/gpu/GrBackendSurface.h | 47 | ||||
-rw-r--r-- | include/gpu/vk/GrVkDefines.h | 4 |
2 files changed, 33 insertions, 18 deletions
diff --git a/include/gpu/GrBackendSurface.h b/include/gpu/GrBackendSurface.h index 232f220282..60a9eb5009 100644 --- a/include/gpu/GrBackendSurface.h +++ b/include/gpu/GrBackendSurface.h @@ -10,32 +10,39 @@ #include "GrTypes.h" #include "gl/GrGLTypes.h" + +#ifdef SK_VULKAN #include "vk/GrVkTypes.h" +#endif class GrBackendTexture { public: GrBackendTexture(int width, int height, - const GrVkImageInfo& vkInfo); + GrPixelConfig config, + const GrGLTextureInfo& glInfo); +#ifdef SK_VULKAN GrBackendTexture(int width, int height, - GrPixelConfig config, - const GrGLTextureInfo& glInfo); + const GrVkImageInfo& vkInfo); +#endif int width() const { return fWidth; } int height() const { return fHeight; } GrPixelConfig config() const { return fConfig; } GrBackend backend() const {return fBackend; } - // If the backend API is Vulkan, this returns a pointer to the GrVkImageInfo struct. Otherwise - // it returns nullptr. - const GrVkImageInfo* getVkImageInfo() const; - // If the backend API is GL, this returns a pointer to the GrGLTextureInfo struct. Otherwise // it returns nullptr. const GrGLTextureInfo* getGLTextureInfo() const; +#ifdef SK_VULKAN + // If the backend API is Vulkan, this returns a pointer to the GrVkImageInfo struct. Otherwise + // it returns nullptr. + const GrVkImageInfo* getVkImageInfo() const; +#endif + private: // Temporary constructor which can be used to convert from a GrBackendTextureDesc. GrBackendTexture(const GrBackendTextureDesc& desc, GrBackend backend); @@ -50,8 +57,10 @@ private: GrBackend fBackend; union { - GrVkImageInfo fVkInfo; GrGLTextureInfo fGLInfo; +#ifdef SK_VULKAN + GrVkImageInfo fVkInfo; +#endif }; }; @@ -61,14 +70,16 @@ public: int height, int sampleCnt, int stencilBits, - const GrVkImageInfo& vkInfo); + GrPixelConfig config, + const GrGLFramebufferInfo& glInfo); +#ifdef SK_VULKAN GrBackendRenderTarget(int width, int height, int sampleCnt, int stencilBits, - GrPixelConfig config, - const GrGLFramebufferInfo& glInfo); + const GrVkImageInfo& vkInfo); +#endif int width() const { return fWidth; } int height() const { return fHeight; } @@ -77,14 +88,16 @@ public: GrPixelConfig config() const { return fConfig; } GrBackend backend() const {return fBackend; } - // If the backend API is Vulkan, this returns a pointer to the GrVkImageInfo struct. Otherwise - // it returns nullptr - const GrVkImageInfo* getVkImageInfo() const; - // If the backend API is GL, this returns a pointer to the GrGLFramebufferInfo struct. Otherwise // it returns nullptr. const GrGLFramebufferInfo* getGLFramebufferInfo() const; +#ifdef SK_VULKAN + // If the backend API is Vulkan, this returns a pointer to the GrVkImageInfo struct. Otherwise + // it returns nullptr + const GrVkImageInfo* getVkImageInfo() const; +#endif + private: // Temporary constructor which can be used to convert from a GrBackendRenderTargetDesc. GrBackendRenderTarget(const GrBackendRenderTargetDesc& desc, GrBackend backend); @@ -102,8 +115,10 @@ private: GrBackend fBackend; union { - GrVkImageInfo fVkInfo; GrGLFramebufferInfo fGLInfo; +#ifdef SK_VULKAN + GrVkImageInfo fVkInfo; +#endif }; }; diff --git a/include/gpu/vk/GrVkDefines.h b/include/gpu/vk/GrVkDefines.h index 7defed2ad5..0bc6fb0343 100644 --- a/include/gpu/vk/GrVkDefines.h +++ b/include/gpu/vk/GrVkDefines.h @@ -31,8 +31,6 @@ # endif #endif -#endif - #include <vulkan/vulkan.h> #define SKIA_REQUIRED_VULKAN_HEADER_VERSION 17 @@ -41,3 +39,5 @@ #endif #endif + +#endif |