diff options
| author |  Xianzhu Wang <wangxianzhu@chromium.org> | 2017-09-25 10:26:40 -0700 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-25 19:05:20 +0000 |
| commit | b449666fa230728fd67b76c990bf49ff726f7134 (patch) | |
| tree | f6a51a9aba8e28d53048d0e103631ce0500e0c17 /include/effects | |
| parent | 477e9d432abd157f52d40ee1aa10263793489d53 (diff) | |
Reland "Fix SkImageSource::filterBounds()" again
This relands commit cb4d58766668b003fea67798027fc25d84acd059
which was reverted by commit b6d2be1330f16fe05f1eed5abda927c0fbb50055
because the original CL broke some blink layout tests, and the first
reland was reverted by commit because it broke filterfastbounds gm.
This reland let SkImageSource::onFilterNodeBounds() return the dst rect
with ctm applied when mapping forward or otherwise the default value.
Original description:
> Previously SkImageSource::filterBounds() uses the default
> SkImageFilter::onFilterNodeBounds() which returns the input rect.
>
> Now override onFilterNodeBounds() in SkImageSource to return src
> or dst rect (with transform applied).
Change-Id: I4548981142b9a96beda8339d394cf9943c9f4c0f
Reviewed-on: https://skia-review.googlesource.com/50420
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Diffstat (limited to 'include/effects')
| -rw-r--r-- | include/effects/SkImageSource.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/effects/SkImageSource.h b/include/effects/SkImageSource.h index 04348c68e8..f2c1274f29 100644 --- a/include/effects/SkImageSource.h +++ b/include/effects/SkImageSource.h @@ -31,6 +31,8 @@ protected: SkIPoint* offset) const override; sk_sp<SkImageFilter> onMakeColorSpace(SkColorSpaceXformer*) const override; + SkIRect onFilterNodeBounds(const SkIRect&, const SkMatrix&, MapDirection) const override; + private: explicit SkImageSource(sk_sp<SkImage>); SkImageSource(sk_sp<SkImage>, |