diff options
| author |  reed <reed@google.com> | 2015-10-06 11:12:23 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-10-06 11:12:23 -0700 |
| commit | 80a6dcaa1b757826ed7414f64b035d512d9ccbf8 (patch) | |
| tree | b77fa8cf50e6954995bf8e53cf0bf07ba72e6544 /include/effects/SkTileImageFilter.h | |
| parent | 85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e (diff) | |
factories should return baseclass, allowing the impl to specialize
waiting on https://codereview.chromium.org/1386163002/# to land
BUG=skia:4424
Review URL: https://codereview.chromium.org/1390523005
Diffstat (limited to 'include/effects/SkTileImageFilter.h')
| -rw-r--r-- | include/effects/SkTileImageFilter.h | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/include/effects/SkTileImageFilter.h b/include/effects/SkTileImageFilter.h index 4dccf852be..a2a1bb0fe1 100644 --- a/include/effects/SkTileImageFilter.h +++ b/include/effects/SkTileImageFilter.h @@ -15,12 +15,11 @@ class SK_API SkTileImageFilter : public SkImageFilter { public: /** Create a tile image filter - @param srcRect Defines the pixels to tile - @param dstRect Defines the pixels where tiles are drawn + @param src Defines the pixels to tile + @param dst Defines the pixels where tiles are drawn @param input Input from which the subregion defined by srcRect will be tiled */ - static SkTileImageFilter* Create(const SkRect& srcRect, const SkRect& dstRect, - SkImageFilter* input); + static SkImageFilter* Create(const SkRect& src, const SkRect& dst, SkImageFilter* input); bool onFilterImage(Proxy* proxy, const SkBitmap& src, const Context& ctx, SkBitmap* dst, SkIPoint* offset) const override; @@ -32,12 +31,12 @@ public: SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkTileImageFilter) protected: - SkTileImageFilter(const SkRect& srcRect, const SkRect& dstRect, SkImageFilter* input) - : INHERITED(1, &input, NULL), fSrcRect(srcRect), fDstRect(dstRect) {} - void flatten(SkWriteBuffer& buffer) const override; private: + SkTileImageFilter(const SkRect& srcRect, const SkRect& dstRect, SkImageFilter* input) + : INHERITED(1, &input, NULL), fSrcRect(srcRect), fDstRect(dstRect) {} + SkRect fSrcRect; SkRect fDstRect; }; |