diff options
author | 2015-10-06 11:12:23 -0700 | |
---|---|---|
committer | 2015-10-06 11:12:23 -0700 | |
commit | 80a6dcaa1b757826ed7414f64b035d512d9ccbf8 (patch) | |
tree | b77fa8cf50e6954995bf8e53cf0bf07ba72e6544 /include/effects/SkTableMaskFilter.h | |
parent | 85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e (diff) |
factories should return baseclass, allowing the impl to specialize
waiting on https://codereview.chromium.org/1386163002/# to land
BUG=skia:4424
Review URL: https://codereview.chromium.org/1390523005
Diffstat (limited to 'include/effects/SkTableMaskFilter.h')
-rw-r--r-- | include/effects/SkTableMaskFilter.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/include/effects/SkTableMaskFilter.h b/include/effects/SkTableMaskFilter.h index 1d530877cc..757ddf2084 100644 --- a/include/effects/SkTableMaskFilter.h +++ b/include/effects/SkTableMaskFilter.h @@ -18,8 +18,6 @@ */ class SK_API SkTableMaskFilter : public SkMaskFilter { public: - virtual ~SkTableMaskFilter(); - /** Utility that sets the gamma table */ static void MakeGammaTable(uint8_t table[256], SkScalar gamma); @@ -29,35 +27,37 @@ public: */ static void MakeClipTable(uint8_t table[256], uint8_t min, uint8_t max); - static SkTableMaskFilter* Create(const uint8_t table[256]) { + static SkMaskFilter* Create(const uint8_t table[256]) { return new SkTableMaskFilter(table); } - static SkTableMaskFilter* CreateGamma(SkScalar gamma) { + static SkMaskFilter* CreateGamma(SkScalar gamma) { uint8_t table[256]; MakeGammaTable(table, gamma); return new SkTableMaskFilter(table); } - static SkTableMaskFilter* CreateClip(uint8_t min, uint8_t max) { + static SkMaskFilter* CreateClip(uint8_t min, uint8_t max) { uint8_t table[256]; MakeClipTable(table, min, max); return new SkTableMaskFilter(table); } SkMask::Format getFormat() const override; - virtual bool filterMask(SkMask*, const SkMask&, const SkMatrix&, - SkIPoint*) const override; + bool filterMask(SkMask*, const SkMask&, const SkMatrix&, SkIPoint*) const override; SK_TO_STRING_OVERRIDE() SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkTableMaskFilter) protected: - SkTableMaskFilter(); - explicit SkTableMaskFilter(const uint8_t table[256]); + virtual ~SkTableMaskFilter(); + void flatten(SkWriteBuffer&) const override; private: + SkTableMaskFilter(); + explicit SkTableMaskFilter(const uint8_t table[256]); + uint8_t fTable[256]; typedef SkMaskFilter INHERITED; |