diff options
author | senorblanco <senorblanco@chromium.org> | 2015-03-18 12:11:33 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-18 12:11:33 -0700 |
commit | 24e06d5244ae96e440410e1d76e039983b2efac9 (patch) | |
tree | a836fa9291bdcfd543cc25edc964527b77b91dba /include/effects/SkMorphologyImageFilter.h | |
parent | 6fbfdb1e5ebe42bf16d929082b43186c8183b063 (diff) |
Remove uniqueID from all filter serialization.
(This is essentially a revert of https://codereview.chromium.org/503833002/.)
This was necessary back when SkPaint was flattened even for in-process use. Now that we only flatten SkPaint for cross-process use, there's no need to serialize UniqueIDs.
Note: SkDropShadowImageFilter is being constructed with a croprect and UniqueID (of 0) in Blink. I've made the uniqueID param default to 0 temporarily, until this rolls in and Blink can be changed. (Blink can't be changed first, since unlike the other filters, there's no constructor that takes a cropRect but not a uniqueID.)
BUG=skia:
Review URL: https://codereview.chromium.org/1019493002
Diffstat (limited to 'include/effects/SkMorphologyImageFilter.h')
-rw-r--r-- | include/effects/SkMorphologyImageFilter.h | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/include/effects/SkMorphologyImageFilter.h b/include/effects/SkMorphologyImageFilter.h index 901955bee6..c5c5c7401e 100644 --- a/include/effects/SkMorphologyImageFilter.h +++ b/include/effects/SkMorphologyImageFilter.h @@ -30,7 +30,7 @@ public: protected: SkMorphologyImageFilter(int radiusX, int radiusY, SkImageFilter* input, - const CropRect* cropRect, uint32_t uniqueID); + const CropRect* cropRect); bool filterImageGeneric(Proc procX, Proc procY, Proxy*, const SkBitmap& src, const Context&, SkBitmap* result, SkIPoint* offset) const; @@ -53,12 +53,11 @@ class SK_API SkDilateImageFilter : public SkMorphologyImageFilter { public: static SkDilateImageFilter* Create(int radiusX, int radiusY, SkImageFilter* input = NULL, - const CropRect* cropRect = NULL, - uint32_t uniqueID = 0) { + const CropRect* cropRect = NULL) { if (radiusX < 0 || radiusY < 0) { return NULL; } - return SkNEW_ARGS(SkDilateImageFilter, (radiusX, radiusY, input, cropRect, uniqueID)); + return SkNEW_ARGS(SkDilateImageFilter, (radiusX, radiusY, input, cropRect)); } virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, @@ -72,8 +71,8 @@ public: SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDilateImageFilter) protected: - SkDilateImageFilter(int radiusX, int radiusY, SkImageFilter* input, const CropRect* cropRect, uint32_t uniqueID) - : INHERITED(radiusX, radiusY, input, cropRect, uniqueID) {} + SkDilateImageFilter(int radiusX, int radiusY, SkImageFilter* input, const CropRect* cropRect) + : INHERITED(radiusX, radiusY, input, cropRect) {} private: typedef SkMorphologyImageFilter INHERITED; }; @@ -82,12 +81,11 @@ class SK_API SkErodeImageFilter : public SkMorphologyImageFilter { public: static SkErodeImageFilter* Create(int radiusX, int radiusY, SkImageFilter* input = NULL, - const CropRect* cropRect = NULL, - uint32_t uniqueID = 0) { + const CropRect* cropRect = NULL) { if (radiusX < 0 || radiusY < 0) { return NULL; } - return SkNEW_ARGS(SkErodeImageFilter, (radiusX, radiusY, input, cropRect, uniqueID)); + return SkNEW_ARGS(SkErodeImageFilter, (radiusX, radiusY, input, cropRect)); } virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, @@ -101,8 +99,8 @@ public: SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkErodeImageFilter) protected: - SkErodeImageFilter(int radiusX, int radiusY, SkImageFilter* input, const CropRect* cropRect, uint32_t uniqueID) - : INHERITED(radiusX, radiusY, input, cropRect, uniqueID) {} + SkErodeImageFilter(int radiusX, int radiusY, SkImageFilter* input, const CropRect* cropRect) + : INHERITED(radiusX, radiusY, input, cropRect) {} private: typedef SkMorphologyImageFilter INHERITED; |