diff options
| author |  reed <reed@google.com> | 2014-08-21 07:59:51 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-08-21 07:59:51 -0700 |
| commit | 9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187 (patch) | |
| tree | 59cc3af7f1a48aec372c05ca29a2fbef703bceb8 /include/effects/SkLumaColorFilter.h | |
| parent | 5d74806b478a884bd763aee7e3e33cff1c506e50 (diff) | |
Simplify flattening to just write enough to call the factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc).
Refactoring pattern:
1. guard the existing constructor(readbuffer) with the legacy build-flag
2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL).
If you're a shader subclass
1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it.
R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/395603002
Diffstat (limited to 'include/effects/SkLumaColorFilter.h')
| -rw-r--r-- | include/effects/SkLumaColorFilter.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/effects/SkLumaColorFilter.h b/include/effects/SkLumaColorFilter.h index 06eb01a1ff..38bab92ce4 100644 --- a/include/effects/SkLumaColorFilter.h +++ b/include/effects/SkLumaColorFilter.h @@ -35,7 +35,9 @@ public: SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkLumaColorFilter) protected: +#ifdef SK_SUPPORT_LEGACY_DEEPFLATTENING SkLumaColorFilter(SkReadBuffer& buffer); +#endif virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE; private: |