diff options
author | reed <reed@chromium.org> | 2015-12-21 08:52:45 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-21 08:52:45 -0800 |
commit | 5e1ddb108638d1d51a3940fcae1dd23adc5ac53b (patch) | |
tree | 8ab43398fb5dcca83c9ef546ac9107658088143b /include/effects/SkCornerPathEffect.h | |
parent | fb56218292d6c7b509d382f39994c3783b2483a0 (diff) |
Reland of change all factories to return their base-class (patchset #1 id:1 of https://codereview.chromium.org/1540203002/ )
Reason for revert:
chrome changes have landed
Original issue's description:
> Revert of change all factories to return their base-class (patchset #1 id:1 of https://codereview.chromium.org/1535353002/ )
>
> Reason for revert:
> need to update some chrome/blink call-sites
>
> Original issue's description:
> > change all factories to return their base-class
> >
> > will watch DEPS roll to see if there are chrome sites needing updates
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535353002
> >
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/d63f60a36327e9580861205ebb35cade8c49bd34
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2d6ba6690f8951e152d8e793191b14afd52f5506
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1533373002
Diffstat (limited to 'include/effects/SkCornerPathEffect.h')
-rw-r--r-- | include/effects/SkCornerPathEffect.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/include/effects/SkCornerPathEffect.h b/include/effects/SkCornerPathEffect.h index 4c8908575d..13095f0e6c 100644 --- a/include/effects/SkCornerPathEffect.h +++ b/include/effects/SkCornerPathEffect.h @@ -20,8 +20,7 @@ public: /** radius must be > 0 to have an effect. It specifies the distance from each corner that should be "rounded". */ - static SkCornerPathEffect* Create(SkScalar radius) { return new SkCornerPathEffect(radius); } - virtual ~SkCornerPathEffect(); + static SkPathEffect* Create(SkScalar radius) { return new SkCornerPathEffect(radius); } virtual bool filterPath(SkPath* dst, const SkPath& src, SkStrokeRec*, const SkRect*) const override; @@ -34,6 +33,8 @@ public: #endif protected: + virtual ~SkCornerPathEffect(); + explicit SkCornerPathEffect(SkScalar radius); void flatten(SkWriteBuffer&) const override; |