diff options
| author |  mtklein <mtklein@chromium.org> | 2016-01-08 11:45:21 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-01-08 11:45:21 -0800 |
| commit | defa0daa6a0f4e97a3527a522ae602c6771a7c80 (patch) | |
| tree | 1d47593806af59cc46dd58a40e99e3b27e2c55ad /include/core | |
| parent | 1a1efeacf7cc94a8c2977114dfe230fed3efc105 (diff) | |
Clean up SkXfermode_opts.h
It seems that MSVC + __vectorcall don't play well together,
so back ourselves out into a situation where we don't need it.
- Inline transfermode functions. This removes the need for SK_VECTORCALL.
- Remove 565 destination specializations.
Blending into 565 is not speed-critical enough to merit the code bloat.
- Removing 565 specializations means a bunch of Sk4px code is now dead.
8888 xfermodes generally speed up a bit from inlining, smoothly ranging from no change down to 0.65x for the fastest functions like Plus or Modulate.
565 xfermodes generally slow down because we're doing 565 -> 8888 and 8888->565 conversion serially[1] and using the stack, smoothly ranging from no change up to 2x slower for the fastest functions like Plus and Modulate.
[1] the 565->8888 conversion is actually being autovectorized
BUG=skia:4765,skia:4776
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1565223002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1565223002
Diffstat (limited to 'include/core')
| -rw-r--r-- | include/core/SkPostConfig.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/include/core/SkPostConfig.h b/include/core/SkPostConfig.h index d23eddf2e6..387ea5b154 100644 --- a/include/core/SkPostConfig.h +++ b/include/core/SkPostConfig.h @@ -300,14 +300,6 @@ # endif #endif -#if defined(SK_BUILD_FOR_WIN) && SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSE2 - #define SK_VECTORCALL __vectorcall -#elif defined(SK_CPU_ARM32) - #define SK_VECTORCALL __attribute__((pcs("aapcs-vfp"))) -#else - #define SK_VECTORCALL -#endif - ////////////////////////////////////////////////////////////////////// #if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSE1 |