diff options
| author |  brianosman <brianosman@google.com> | 2016-09-09 10:36:17 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-09-09 10:36:17 -0700 |
| commit | de68d6c4616d86621373d88100002ddfdb9c08e3 (patch) | |
| tree | c3020d0d2ab8a4157beeab02fc32efc1518bb1e6 /include/core | |
| parent | 81a478ca6c36aac3e53ce0373a281ac8940f4780 (diff) | |
Fix storage of gamut transform matrices in SkColorSpace
We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.
I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003
Review-Url: https://codereview.chromium.org/2324843003
Diffstat (limited to 'include/core')
| -rw-r--r-- | include/core/SkMatrix44.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/core/SkMatrix44.h b/include/core/SkMatrix44.h index 6b5e65d072..9820ee58cd 100644 --- a/include/core/SkMatrix44.h +++ b/include/core/SkMatrix44.h @@ -457,8 +457,8 @@ private: kAllPublic_Masks = 0xF }; - void as4x3ColMajorf(float[]) const; - void set4x3ColMajorf(const float[]); + void as3x4RowMajorf(float[]) const; + void set3x4RowMajorf(const float[]); SkMScalar transX() const { return fMat[3][0]; } SkMScalar transY() const { return fMat[3][1]; } |