diff options
| author |  benjaminwagner <benjaminwagner@google.com> | 2016-02-24 06:51:52 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-02-24 06:51:52 -0800 |
| commit | 7ea5cb18389db11a94175de95c9db2b44972630c (patch) | |
| tree | 3e87b6ec8c453081a1666fca96dfb5bfbbda2141 /include/core | |
| parent | 8f7b0b2d809510d4af4e6ff6f731bac78eded6c4 (diff) | |
Cleanups related to SkFixed.
Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
Review URL: https://codereview.chromium.org/1683743005
Diffstat (limited to 'include/core')
| -rw-r--r-- | include/core/SkFixed.h | 1 | ||||
| -rw-r--r-- | include/core/SkRect.h | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/include/core/SkFixed.h b/include/core/SkFixed.h index f6dd3d6002..1541e32105 100644 --- a/include/core/SkFixed.h +++ b/include/core/SkFixed.h @@ -22,7 +22,6 @@ typedef int32_t SkFixed; #define SK_FixedHalf (1 << 15) #define SK_FixedMax (0x7FFFFFFF) #define SK_FixedMin (-SK_FixedMax) -#define SK_FixedNaN ((int) 0x80000000) #define SK_FixedPI (0x3243F) #define SK_FixedSqrt2 (92682) #define SK_FixedTanPIOver8 (0x6A0A) diff --git a/include/core/SkRect.h b/include/core/SkRect.h index 4f649b7c73..3ebe099ae6 100644 --- a/include/core/SkRect.h +++ b/include/core/SkRect.h @@ -463,8 +463,7 @@ struct SK_API SkRect { /** * Returns true iff all values in the rect are finite. If any are - * infinite or NaN (or SK_FixedNaN when SkScalar is fixed) then this - * returns false. + * infinite or NaN then this returns false. */ bool isFinite() const { float accum = 0; |