diff options
author | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-10-17 16:29:21 +0000 |
---|---|---|
committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-10-17 16:29:21 +0000 |
commit | 521a46750d87d3d206617d05d917ad6aad242ca4 (patch) | |
tree | 772cb406835c8fe36895c0c13624b51a43904a8b /include/core | |
parent | 627f66283b16dab30b31b381e35795104b70a56b (diff) |
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance.
R=bsalomon@google.com, robertphillips@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/23484007
git-svn-id: http://skia.googlecode.com/svn/trunk@11842 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'include/core')
-rw-r--r-- | include/core/SkCanvas.h | 26 |
1 files changed, 22 insertions, 4 deletions
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h index dc3953ed4b..8c09a9c91e 100644 --- a/include/core/SkCanvas.h +++ b/include/core/SkCanvas.h @@ -575,16 +575,20 @@ public: will be filled or stroked based on the Style in the paint. @param rect The rect to be drawn @param paint The paint used to draw the rect + + Overriding this function is deprecated. It will be made non-virtual + soon. Instead override onDrawRect. */ - virtual void drawRect(const SkRect& rect, const SkPaint& paint); + virtual void drawRect(const SkRect& rect, const SkPaint& paint) { + this->onDrawRect(rect, paint); + } /** Draw the specified rectangle using the specified paint. The rectangle will be filled or framed based on the Style in the paint. @param rect The rect to be drawn @param paint The paint used to draw the rect */ - void drawIRect(const SkIRect& rect, const SkPaint& paint) - { + void drawIRect(const SkIRect& rect, const SkPaint& paint) { SkRect r; r.set(rect); // promotes the ints to scalars this->drawRect(r, paint); @@ -656,8 +660,18 @@ public: filled or framed based on the Style in the paint. @param path The path to be drawn @param paint The paint used to draw the path + + Overriding this function is deprecated. It will be made non-virtual + soon. Instead override onDrawRect. */ - virtual void drawPath(const SkPath& path, const SkPaint& paint); + virtual void drawPath(const SkPath& path, const SkPaint& paint) { + SkRect rect; + if (path.isRect(&rect)) { + this->onDrawRect(rect, paint); + } else { + this->onDrawPath(path, paint); + } + } /** Draw the specified bitmap, with its top/left corner at (x,y), using the specified paint, transformed by the current matrix. Note: if the paint @@ -1034,6 +1048,10 @@ protected: // can perform copy-on-write or invalidate any cached images void predrawNotify(); + virtual void onDrawRect(const SkRect& rect, const SkPaint& paint); + + virtual void onDrawPath(const SkPath& path, const SkPaint& paint); + /** DEPRECATED -- use constructor(device) Marked as 'protected' to avoid new clients using this before we can |