diff options
author | 2011-10-03 16:01:10 +0000 | |
---|---|---|
committer | 2011-10-03 16:01:10 +0000 | |
commit | 1341304449a60713bf9c8ea2e9489f35533f037a (patch) | |
tree | 7c8a9cae677d58e723de09f19db4e8af756575af /include/core | |
parent | 7430a3376c0f4e0c2809fedecd12765034f9e3a8 (diff) |
Use SK_OVERRIDE to add a little extra robustness against name changes.
git-svn-id: http://skia.googlecode.com/svn/trunk@2395 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'include/core')
-rw-r--r-- | include/core/SkBlitter.h | 39 | ||||
-rw-r--r-- | include/core/SkColorFilter.h | 4 | ||||
-rw-r--r-- | include/core/SkPathEffect.h | 6 | ||||
-rw-r--r-- | include/core/SkPostConfig.h | 16 | ||||
-rw-r--r-- | include/core/SkRasterizer.h | 2 | ||||
-rw-r--r-- | include/core/SkShader.h | 2 | ||||
-rw-r--r-- | include/core/SkStream.h | 38 | ||||
-rw-r--r-- | include/core/SkXfermode.h | 12 |
8 files changed, 69 insertions, 50 deletions
diff --git a/include/core/SkBlitter.h b/include/core/SkBlitter.h index 284ce6a7a2..18ec1e16a5 100644 --- a/include/core/SkBlitter.h +++ b/include/core/SkBlitter.h @@ -64,12 +64,13 @@ private: */ class SkNullBlitter : public SkBlitter { public: - virtual void blitH(int x, int y, int width); - virtual void blitAntiH(int x, int y, const SkAlpha[], const int16_t runs[]); - virtual void blitV(int x, int y, int height, SkAlpha alpha); - virtual void blitRect(int x, int y, int width, int height); - virtual void blitMask(const SkMask&, const SkIRect& clip); - virtual const SkBitmap* justAnOpaqueColor(uint32_t* value); + virtual void blitH(int x, int y, int width) SK_OVERRIDE; + virtual void blitAntiH(int x, int y, const SkAlpha[], + const int16_t runs[]) SK_OVERRIDE; + virtual void blitV(int x, int y, int height, SkAlpha alpha) SK_OVERRIDE; + virtual void blitRect(int x, int y, int width, int height) SK_OVERRIDE; + virtual void blitMask(const SkMask&, const SkIRect& clip) SK_OVERRIDE; + virtual const SkBitmap* justAnOpaqueColor(uint32_t* value) SK_OVERRIDE; }; /** Wraps another (real) blitter, and ensures that the real blitter is only @@ -85,12 +86,13 @@ public: } // overrides - virtual void blitH(int x, int y, int width); - virtual void blitAntiH(int x, int y, const SkAlpha[], const int16_t runs[]); - virtual void blitV(int x, int y, int height, SkAlpha alpha); - virtual void blitRect(int x, int y, int width, int height); - virtual void blitMask(const SkMask&, const SkIRect& clip); - virtual const SkBitmap* justAnOpaqueColor(uint32_t* value); + virtual void blitH(int x, int y, int width) SK_OVERRIDE; + virtual void blitAntiH(int x, int y, const SkAlpha[], + const int16_t runs[]) SK_OVERRIDE; + virtual void blitV(int x, int y, int height, SkAlpha alpha) SK_OVERRIDE; + virtual void blitRect(int x, int y, int width, int height) SK_OVERRIDE; + virtual void blitMask(const SkMask&, const SkIRect& clip) SK_OVERRIDE; + virtual const SkBitmap* justAnOpaqueColor(uint32_t* value) SK_OVERRIDE; private: SkBlitter* fBlitter; @@ -110,12 +112,13 @@ public: } // overrides - virtual void blitH(int x, int y, int width); - virtual void blitAntiH(int x, int y, const SkAlpha[], const int16_t runs[]); - virtual void blitV(int x, int y, int height, SkAlpha alpha); - virtual void blitRect(int x, int y, int width, int height); - virtual void blitMask(const SkMask&, const SkIRect& clip); - virtual const SkBitmap* justAnOpaqueColor(uint32_t* value); + virtual void blitH(int x, int y, int width) SK_OVERRIDE; + virtual void blitAntiH(int x, int y, const SkAlpha[], + const int16_t runs[]) SK_OVERRIDE; + virtual void blitV(int x, int y, int height, SkAlpha alpha) SK_OVERRIDE; + virtual void blitRect(int x, int y, int width, int height) SK_OVERRIDE; + virtual void blitMask(const SkMask&, const SkIRect& clip) SK_OVERRIDE; + virtual const SkBitmap* justAnOpaqueColor(uint32_t* value) SK_OVERRIDE; private: SkBlitter* fBlitter; diff --git a/include/core/SkColorFilter.h b/include/core/SkColorFilter.h index 0ee36f12d3..3b9bb4d643 100644 --- a/include/core/SkColorFilter.h +++ b/include/core/SkColorFilter.h @@ -119,8 +119,8 @@ public: protected: SkFilterShader(SkFlattenableReadBuffer& ); - virtual void flatten(SkFlattenableWriteBuffer& ); - virtual Factory getFactory() { return CreateProc; } + virtual void flatten(SkFlattenableWriteBuffer& ) SK_OVERRIDE; + virtual Factory getFactory() SK_OVERRIDE { return CreateProc; } private: static SkFlattenable* CreateProc(SkFlattenableReadBuffer& buffer) { return SkNEW_ARGS(SkFilterShader, (buffer)); } diff --git a/include/core/SkPathEffect.h b/include/core/SkPathEffect.h index a37cba7869..880219fead 100644 --- a/include/core/SkPathEffect.h +++ b/include/core/SkPathEffect.h @@ -53,7 +53,7 @@ public: protected: SkPairPathEffect(SkFlattenableReadBuffer&); - virtual void flatten(SkFlattenableWriteBuffer&); + virtual void flatten(SkFlattenableWriteBuffer&) SK_OVERRIDE; // these are visible to our subclasses SkPathEffect* fPE0, *fPE1; @@ -85,7 +85,7 @@ public: } protected: - virtual Factory getFactory() { return CreateProc; } + virtual Factory getFactory() SK_OVERRIDE { return CreateProc; } private: SkComposePathEffect(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) {} @@ -120,7 +120,7 @@ public: } protected: - virtual Factory getFactory() { return CreateProc; } + virtual Factory getFactory() SK_OVERRIDE { return CreateProc; } private: SkSumPathEffect(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) {} diff --git a/include/core/SkPostConfig.h b/include/core/SkPostConfig.h index 4c494dd671..0135b85f9e 100644 --- a/include/core/SkPostConfig.h +++ b/include/core/SkPostConfig.h @@ -245,7 +245,23 @@ #define DEBUG_CLIENTBLOCK #endif // _DEBUG + +#endif + #endif +////////////////////////////////////////////////////////////////////// + +#ifndef SK_OVERRIDE +#if defined(SK_BUILD_FOR_WIN) +#define SK_OVERRIDE override +#elif defined(__clang__) +// Some documentation suggests we should be using __attribute__((override)), +// but it doesn't work. +#define SK_OVERRIDE override +#else +// Linux GCC ignores "__attribute__((override))" and rejects "override". +#define SK_OVERRIDE +#endif #endif diff --git a/include/core/SkRasterizer.h b/include/core/SkRasterizer.h index 7a49b5f3e6..d249898eda 100644 --- a/include/core/SkRasterizer.h +++ b/include/core/SkRasterizer.h @@ -28,7 +28,7 @@ public: const SkIRect* clipBounds, SkMaskFilter* filter, SkMask* mask, SkMask::CreateMode mode); - virtual void flatten(SkFlattenableWriteBuffer& ) {} + virtual void flatten(SkFlattenableWriteBuffer& ) SK_OVERRIDE {} protected: SkRasterizer(SkFlattenableReadBuffer&); diff --git a/include/core/SkShader.h b/include/core/SkShader.h index 66bb1876c1..db737c90b7 100644 --- a/include/core/SkShader.h +++ b/include/core/SkShader.h @@ -270,7 +270,7 @@ public: static SkShader* CreateBitmapShader(const SkBitmap& src, TileMode tmx, TileMode tmy); - virtual void flatten(SkFlattenableWriteBuffer& ); + virtual void flatten(SkFlattenableWriteBuffer& ) SK_OVERRIDE; protected: enum MatrixClass { kLinear_MatrixClass, // no perspective diff --git a/include/core/SkStream.h b/include/core/SkStream.h index a44ac737c9..90d235714f 100644 --- a/include/core/SkStream.h +++ b/include/core/SkStream.h @@ -124,9 +124,9 @@ public: */ void setPath(const char path[]); - virtual bool rewind(); - virtual size_t read(void* buffer, size_t size); - virtual const char* getFileName(); + virtual bool rewind() SK_OVERRIDE; + virtual size_t read(void* buffer, size_t size) SK_OVERRIDE; + virtual const char* getFileName() SK_OVERRIDE; private: SkFILE* fFILE; @@ -148,9 +148,9 @@ public: */ bool isValid() const { return fFD >= 0; } - virtual bool rewind(); - virtual size_t read(void* buffer, size_t size); - virtual const char* getFileName() { return NULL; } + virtual bool rewind() SK_OVERRIDE; + virtual size_t read(void* buffer, size_t size) SK_OVERRIDE; + virtual const char* getFileName() SK_OVERRIDE { return NULL; } private: int fFD; @@ -194,9 +194,9 @@ public: SkData* setData(SkData*); void skipToAlign4(); - virtual bool rewind(); - virtual size_t read(void* buffer, size_t size); - virtual const void* getMemoryBase(); + virtual bool rewind() SK_OVERRIDE; + virtual size_t read(void* buffer, size_t size) SK_OVERRIDE; + virtual const void* getMemoryBase() SK_OVERRIDE; const void* getAtPos(); size_t seek(size_t offset); size_t peek() const { return fOffset; } @@ -230,10 +230,10 @@ public: SkBufferStream(SkStream* proxy, void* buffer, size_t bufferSize); virtual ~SkBufferStream(); - virtual bool rewind(); - virtual const char* getFileName(); - virtual size_t read(void* buffer, size_t size); - virtual const void* getMemoryBase(); + virtual bool rewind() SK_OVERRIDE; + virtual const char* getFileName() SK_OVERRIDE; + virtual size_t read(void* buffer, size_t size) SK_OVERRIDE; + virtual const void* getMemoryBase() SK_OVERRIDE; private: enum { @@ -262,8 +262,8 @@ public: */ bool isValid() const { return fFILE != NULL; } - virtual bool write(const void* buffer, size_t size); - virtual void flush(); + virtual bool write(const void* buffer, size_t size) SK_OVERRIDE; + virtual void flush() SK_OVERRIDE; private: SkFILE* fFILE; }; @@ -271,7 +271,7 @@ private: class SkMemoryWStream : public SkWStream { public: SkMemoryWStream(void* buffer, size_t size); - virtual bool write(const void* buffer, size_t size); + virtual bool write(const void* buffer, size_t size) SK_OVERRIDE; private: char* fBuffer; @@ -284,7 +284,7 @@ public: SkDynamicMemoryWStream(); virtual ~SkDynamicMemoryWStream(); - virtual bool write(const void* buffer, size_t size); + virtual bool write(const void* buffer, size_t size) SK_OVERRIDE; // random access write // modifies stream and returns true if offset + size is less than or equal to getOffset() bool write(const void* buffer, size_t offset, size_t size); @@ -318,8 +318,8 @@ private: class SkDebugWStream : public SkWStream { public: // overrides - virtual bool write(const void* buffer, size_t size); - virtual void newline(); + virtual bool write(const void* buffer, size_t size) SK_OVERRIDE; + virtual void newline() SK_OVERRIDE; }; // for now diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h index 7eedc1d364..592689ca15 100644 --- a/include/core/SkXfermode.h +++ b/include/core/SkXfermode.h @@ -193,17 +193,17 @@ public: // overrides from SkXfermode virtual void xfer32(SkPMColor dst[], const SkPMColor src[], int count, - const SkAlpha aa[]); + const SkAlpha aa[]) SK_OVERRIDE; virtual void xfer16(uint16_t dst[], const SkPMColor src[], int count, - const SkAlpha aa[]); + const SkAlpha aa[]) SK_OVERRIDE; virtual void xfer4444(uint16_t dst[], const SkPMColor src[], int count, - const SkAlpha aa[]); + const SkAlpha aa[]) SK_OVERRIDE; virtual void xferA8(SkAlpha dst[], const SkPMColor src[], int count, - const SkAlpha aa[]); + const SkAlpha aa[]) SK_OVERRIDE; // overrides from SkFlattenable - virtual Factory getFactory() { return CreateProc; } - virtual void flatten(SkFlattenableWriteBuffer&); + virtual Factory getFactory() SK_OVERRIDE { return CreateProc; } + virtual void flatten(SkFlattenableWriteBuffer&) SK_OVERRIDE; protected: SkProcXfermode(SkFlattenableReadBuffer&); |