diff options
author | 2016-10-03 18:02:50 +0000 | |
---|---|---|
committer | 2016-10-03 18:03:29 +0000 | |
commit | ce02e7175872abde3721df9e5d3ec0ab8384cd8e (patch) | |
tree | 620eec63e1082137df3111d09cd2bf1eb7ebd180 /include/core/SkXfermode.h | |
parent | 6fb592e6afb0061c9c0af15ddf599e2903f508f1 (diff) |
Revert "replace SkXfermode obj with SkBlendMode enum in paints"
This reverts commit I4fb489ba6b3f77b458f7e4a99f79c7ad10859135.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> replace SkXfermode obj with SkBlendMode enum in paints
>
> BUG=skia:5814
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714
>
> Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135
> Reviewed-on: https://skia-review.googlesource.com/2714
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>
TBR=bsalomon@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I3e43f79ef5c1709929663fe63cc1f67cd78270b7
Reviewed-on: https://skia-review.googlesource.com/2871
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'include/core/SkXfermode.h')
-rw-r--r-- | include/core/SkXfermode.h | 32 |
1 files changed, 1 insertions, 31 deletions
diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h index 8319ad6882..2d12b3c931 100644 --- a/include/core/SkXfermode.h +++ b/include/core/SkXfermode.h @@ -8,9 +8,8 @@ #ifndef SkXfermode_DEFINED #define SkXfermode_DEFINED -#include "SkBlendMode.h" -#include "SkColor.h" #include "SkFlattenable.h" +#include "SkColor.h" class GrFragmentProcessor; class GrTexture; @@ -113,9 +112,6 @@ public: * Gets the name of the Mode as a string. */ static const char* ModeName(Mode); - static const char* ModeName(SkBlendMode mode) { - return ModeName(Mode(mode)); - } /** * If the xfermode is one of the modes in the Mode enum, then asMode() @@ -161,31 +157,6 @@ public: } #endif - /** - * Skia maintains global xfermode objects corresponding to each BlendMode. This returns a - * ptr to that global xfermode (or null if the mode is srcover). Thus the caller may use - * the returned ptr, but it should leave its refcnt untouched. - */ - static SkXfermode* Peek(SkBlendMode mode) { - sk_sp<SkXfermode> xfer = Make(mode); - if (!xfer) { - SkASSERT(SkBlendMode::kSrcOver == mode); - return nullptr; - } - SkASSERT(!xfer->unique()); - return xfer.get(); - } - - static sk_sp<SkXfermode> Make(SkBlendMode bm) { - return Make((Mode)bm); - } - - SkBlendMode blend() const { - Mode mode; - SkAssertResult(this->asMode(&mode)); - return (SkBlendMode)mode; - } - /** Return a function pointer to a routine that applies the specified porter-duff transfer mode. */ @@ -244,7 +215,6 @@ public: static bool IsOpaque(const sk_sp<SkXfermode>& xfer, SrcColorOpacity opacityType) { return IsOpaque(xfer.get(), opacityType); } - static bool IsOpaque(SkBlendMode, SrcColorOpacity); #if SK_SUPPORT_GPU /** Used by the SkXfermodeImageFilter to blend two colors via a GrFragmentProcessor. |