diff options
| author |  benjaminwagner <benjaminwagner@google.com> | 2016-02-24 08:29:11 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-02-24 08:29:11 -0800 |
| commit | c2d35d851365bb89f392fe2dd7af57e169de26b7 (patch) | |
| tree | afa19bb232e8406edd7b29e2d4240da55ed04782 /include/core/SkRect.h | |
| parent | f15b07b75ce6b1ad2bde91b3baf17ef9210241b3 (diff) | |
Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/1683743005/ )
Reason for revert:
New test is failing on Windows.
Original issue's description:
> Cleanups related to SkFixed.
>
> Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
>
> Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
>
> Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
>
> BUG=skia:4632
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
>
> Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c
TBR=mtklein@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4632
Review URL: https://codereview.chromium.org/1724283003
Diffstat (limited to 'include/core/SkRect.h')
| -rw-r--r-- | include/core/SkRect.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/core/SkRect.h b/include/core/SkRect.h index 3ebe099ae6..4f649b7c73 100644 --- a/include/core/SkRect.h +++ b/include/core/SkRect.h @@ -463,7 +463,8 @@ struct SK_API SkRect { /** * Returns true iff all values in the rect are finite. If any are - * infinite or NaN then this returns false. + * infinite or NaN (or SK_FixedNaN when SkScalar is fixed) then this + * returns false. */ bool isFinite() const { float accum = 0; |