diff options
| author |  Ben Wagner <benjaminwagner@google.com> | 2017-10-09 12:29:42 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-10-09 16:48:04 +0000 |
| commit | b6abb9b4e088abee8b8dfcce9c9f7eb759518198 (patch) | |
| tree | 0e58348b825658e36b4e60e3f782bf8c1b6d11b6 /include/core/SkRect.h | |
| parent | 72818018494372b8692203b77aedfa6b8a87e3bc (diff) | |
Revert "Fix a couple float-cast-overflow in SkScan*."
This reverts commit 3cd0bef0fd9d062bbcc313c329b4f31925e8ded7.
Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143
Original change's description:
> Fix a couple float-cast-overflow in SkScan*.
>
> Bug: skia:5060
> Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4
> Reviewed-on: https://skia-review.googlesource.com/47422
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
TBR=benjaminwagner@google.com,reed@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: skia:7143
Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae
Reviewed-on: https://skia-review.googlesource.com/57240
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Diffstat (limited to 'include/core/SkRect.h')
| -rw-r--r-- | include/core/SkRect.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/include/core/SkRect.h b/include/core/SkRect.h index 12afddd9ce..2cc2604941 100644 --- a/include/core/SkRect.h +++ b/include/core/SkRect.h @@ -411,14 +411,6 @@ struct SK_API SkRect { return r; } - // The largest SkRect for which round() is well-defined. - static SkRect SK_WARN_UNUSED_RESULT MakeLargestS32() { - const SkRect r = MakeLTRB(SK_MinS32FitsInFloat, SK_MinS32FitsInFloat, - SK_MaxS32FitsInFloat, SK_MaxS32FitsInFloat); - SkASSERT(r == Make(r.roundOut())); - return r; - } - static constexpr SkRect SK_WARN_UNUSED_RESULT MakeWH(SkScalar w, SkScalar h) { return SkRect{0, 0, w, h}; } |