diff options
| author |  Mike Klein <mtklein@chromium.org> | 2017-10-11 17:13:28 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-10-12 15:29:11 +0000 |
| commit | 20d479c088ad6dc06e16b13a3e6b2dfefa845430 (patch) | |
| tree | 53913c9a5f80b1a41896164952535d808c0f3c3c /include/core/SkRRect.h | |
| parent | 298143ebdfd55f83c7493760bf3d844a4ac8325a (diff) | |
abort SkRRect::transform() before dst->scaleRadii() asserts
If we've got a crazy matrix, we can make dst arbitrarily crazy.
This should fix several of Kevin's fuzzes, e.g.
Bug: skia:7090
I don't see any uses of SkRRect::transform() that care about
the output rrect in case of failure, so I've just removed the
guarantee that we don't modify it when failing.
Change-Id: I4c81af59a093a984f0a02a0d3dc4bbbb1fb935f2
Reviewed-on: https://skia-review.googlesource.com/58620
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'include/core/SkRRect.h')
| -rw-r--r-- | include/core/SkRRect.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/core/SkRRect.h b/include/core/SkRRect.h index 0a231b6a2c..28b3fc441e 100644 --- a/include/core/SkRRect.h +++ b/include/core/SkRRect.h @@ -327,7 +327,7 @@ public: * scale and/or translate, or this call will fail. * @param dst SkRRect to store the result. It is an error to use this, * which would make this function no longer const. - * @return true on success, false on failure. If false, dst is unmodified. + * @return true on success, false on failure. */ bool transform(const SkMatrix& matrix, SkRRect* dst) const; |