aboutsummaryrefslogtreecommitdiffhomepage
path: root/include/core/SkPaint.h
diff options
context:
space:
mode:
authorGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-03-24 23:03:11 +0000
committerGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-03-24 23:03:11 +0000
commite8807f49ed24be3933acf84c9ffa840a03fa43dc (patch)
treeb9c4a437bd0132a5e5636c900d4db50809e43632 /include/core/SkPaint.h
parenta2b44dc5882856b6ed3670f370819ab39998ada8 (diff)
SkPaint: eliminate some dead bytes in 64-bit build.
+ memcpy-based copy constructor was hiding this gap -> manual copy constructor. + Split tests for finer-grained failures. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13856 Committed: http://code.google.com/p/skia/source/detail?r=13887 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/203203003 git-svn-id: http://skia.googlecode.com/svn/trunk@13927 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'include/core/SkPaint.h')
-rw-r--r--include/core/SkPaint.h12
1 files changed, 5 insertions, 7 deletions
diff --git a/include/core/SkPaint.h b/include/core/SkPaint.h
index e86d01195c..7a647f0ea2 100644
--- a/include/core/SkPaint.h
+++ b/include/core/SkPaint.h
@@ -1046,10 +1046,6 @@ public:
private:
SkTypeface* fTypeface;
- SkScalar fTextSize;
- SkScalar fTextScaleX;
- SkScalar fTextSkewX;
-
SkPathEffect* fPathEffect;
SkShader* fShader;
SkXfermode* fXfermode;
@@ -1060,10 +1056,12 @@ private:
SkImageFilter* fImageFilter;
SkAnnotation* fAnnotation;
+ SkScalar fTextSize;
+ SkScalar fTextScaleX;
+ SkScalar fTextSkewX;
SkColor fColor;
SkScalar fWidth;
SkScalar fMiterLimit;
-
union {
struct {
// all of these bitfields should add up to 32
@@ -1078,11 +1076,11 @@ private:
};
uint32_t fBitfields;
};
+ uint32_t fDirtyBits;
+
uint32_t getBitfields() const { return fBitfields; }
void setBitfields(uint32_t bitfields);
- uint32_t fDirtyBits;
-
SkDrawCacheProc getDrawCacheProc() const;
SkMeasureCacheProc getMeasureCacheProc(TextBufferDirection dir,
bool needFullMetrics) const;