Fix argument names and documentation for SkMatrix44::set3x3()

Column-major is an implementation choice, not an interface. There is
exactly one acceptable subscript notation for indexing matrix elements,
and it's row first, then column. Having these named backwards was
unnecessarily confusing.

Note that this doesn't alter behavior in any way, it just brings this
function in line with expectations from any reasonable mathematician.

Change-Id: Ie4ceb40281ef507889d25403afbf24116514c45a
Reviewed-on: https://skia-review.googlesource.com/122790
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/include/core/SkMatrix44.h b/include/core/SkMatrix44.h
index 398204cc20..790cd9c7fa 100644
--- a/include/core/SkMatrix44.h
+++ b/include/core/SkMatrix44.h
@@ -328,11 +328,11 @@ public:
 #endif
 
     /* This sets the top-left of the matrix and clears the translation and
-     * perspective components (with [3][3] set to 1).  mXY is interpreted
-     * as the matrix entry at col = X, row = Y. */
-    void set3x3(SkMScalar m00, SkMScalar m01, SkMScalar m02,
-                SkMScalar m10, SkMScalar m11, SkMScalar m12,
-                SkMScalar m20, SkMScalar m21, SkMScalar m22);
+     * perspective components (with [3][3] set to 1).  m_ij is interpreted
+     * as the matrix entry at row = i, col = j. */
+    void set3x3(SkMScalar m_00, SkMScalar m_10, SkMScalar m_20,
+                SkMScalar m_01, SkMScalar m_11, SkMScalar m_21,
+                SkMScalar m_02, SkMScalar m_12, SkMScalar m_22);
     void set3x3RowMajorf(const float[]);
 
     void setTranslate(SkMScalar dx, SkMScalar dy, SkMScalar dz);