diff options
author | Jim Van Verth <jvanverth@google.com> | 2017-09-27 22:13:44 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-27 23:15:07 +0000 |
commit | 809cbedd4b252be221b2ac3b4269d312fd8f53a0 (patch) | |
tree | 66ff73d8acfd81ebf76afd36d44a06709a4ba457 /include/core/SkBitmap.h | |
parent | 6ca9c6f41224050d92cae548e915f5b9175efe8b (diff) |
Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"
This reverts commit 88757dacd4f532a0f647c02ae0ee596d31ab5c68.
Reason for revert: Still seems to be failing Chromium "telemetry_perf_unittests (with patch) on Android" on android_n5x_swarming_rel.
Original change's description:
> guard old apis for querying byte-size of a bitmap/imageinfo/pixmap
>
> Now with legacy behavior for allocpixels
>
> This was reverted, so the current CL is a "fix" on top of ...
> https://skia-review.googlesource.com/c/skia/+/50980
>
> Related update to Chrome (in preparation for this change)
> https://chromium-review.googlesource.com/c/chromium/src/+/685719
>
> Bug: skia:
> Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9
> Reviewed-on: https://skia-review.googlesource.com/51341
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@google.com>
TBR=fmalita@chromium.org,reed@google.com
Change-Id: I827a0ca1d1e3909e648fde3342cdb8601d34da8d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/52381
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Diffstat (limited to 'include/core/SkBitmap.h')
-rw-r--r-- | include/core/SkBitmap.h | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/include/core/SkBitmap.h b/include/core/SkBitmap.h index cea50b8886..7425eb03d5 100644 --- a/include/core/SkBitmap.h +++ b/include/core/SkBitmap.h @@ -141,13 +141,10 @@ public: */ void* getPixels() const { return fPixels; } - /** - * Returns the size (in bytes) of the bitmap's image buffer. - * If the calculation overflows, or if the height is 0, this returns 0. - */ - size_t computeByteSize() const { return fInfo.computeByteSize(fRowBytes); } - -#ifdef SK_SUPPORT_LEGACY_SAFESIZE64 + /** Return the byte size of the pixels, based on the height and rowBytes. + Note this truncates the result to 32bits. Call getSize64() to detect + if the real size exceeds 32bits. + */ size_t getSize() const { return fInfo.height() * fRowBytes; } /** Return the number of bytes from the pointer returned by getPixels() @@ -171,7 +168,6 @@ public: int64_t computeSafeSize64() const { return fInfo.getSafeSize64(fRowBytes); } -#endif /** Returns true if this bitmap is marked as immutable, meaning that the contents of its pixels will not change for the lifetime of the bitmap. |