diff options
| author |  bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-18 15:27:39 +0000 |
|---|---|---|
| committer | bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-18 15:27:39 +0000 |
| commit | d9947f605a335363b0a0541d6d8cb7a7113ed788 (patch) | |
| tree | adfece12609a5ca87c8e2ea387c0dba31699f2b6 /include/config | |
| parent | e2380570de11226a93362d017e93c4790641c027 (diff) | |
Split atomic and mutex implementations and make inlinable.
Skia cannot use Chromium's implementation of mutex (Lock) due to static
initializers. However, we would like to be able to use Chromium's
implementation of atomics. This motivates the split of implementation.
Skia's atomic and mutex calls should be inlinable, especially the atomics.
These calls often compile down to very few instructions, and we currently have
the overhead of a function call. This motivates the header implementation.
There is still a desire for the build system to select the implementation, so
the SK_XXX_PLATFORM_H pattern for header files is introduced. This allows the
build system to control which platform specific header files are chosen.
The Chromium side changes (most of which will need to go in before this change
can be found at https://codereview.chromium.org/19477005/ .
The Chromium side changes after this lands can be seen at
https://codereview.chromium.org/98073013 .
Review URL: https://codereview.chromium.org/19808007
git-svn-id: http://skia.googlecode.com/svn/trunk@12738 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'include/config')
| -rw-r--r-- | include/config/SkUserConfig.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/include/config/SkUserConfig.h b/include/config/SkUserConfig.h index 72994e4060..534c79dde1 100644 --- a/include/config/SkUserConfig.h +++ b/include/config/SkUserConfig.h @@ -186,4 +186,13 @@ */ //#define SK_PDF_USE_PATHOPS +/* Skia uses these defines as the target of include preprocessor directives. + * The header files pointed to by these defines provide declarations and + * possibly inline implementations of threading primitives. + * + * See SkThread.h for documentation on what these includes must contain. + */ +//#define SK_ATOMICS_PLATFORM_H "SkAtomics_xxx.h" +//#define SK_MUTEX_PLATFORM_H "SkMutex_xxx.h" + #endif |